Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuselage-ui-kit): add URL option to the overflow component #737

Merged
merged 7 commits into from
Jul 4, 2022

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Jun 3, 2022

Proposed changes (including videos or screenshots)

Allow passing an URL to the Overflow component options. When an option has the URL prop, open it in a new tab before triggering the action;

Issue(s)

Further comments

This feature will allow opening a link inside the overflow component, as it's possible with the button component. We will need it to develop the Google Drive app.
More info here

@CLAassistant
Copy link

CLAassistant commented Jun 3, 2022

CLA assistant check
All committers have signed the CLA.

@tapiarafael
Copy link
Member Author

Maybe it's a good time to change the ObjectType from an array to an object? I didn't do it because it'll require many changes in other components besides the Overflow element.

@d-gubert d-gubert requested a review from tassoevan June 10, 2022 18:41
@d-gubert d-gubert requested a review from ggazzo June 28, 2022 21:53
@ggazzo ggazzo merged commit a250c04 into RocketChat:develop Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants