Password change field should be disabled, if password change is disabled

[phriedrich]

• Your Rocket.Chat Experimental app version: 1.25.0.12983
• Your Rocket.Chat server version: 2.3.0
• Device (or Simulator) you're running with: iPad w/ iPad OS 13.2.3

We get the user information via LDAP and disabled the option to change the user's password within Rocket.Chat.

On the web version, the password change field in the user's profile settings is correctly disabled and can not be selected.

In the app I can (try) to set a new password, at least I can select the field and write something. The field should be disabled if the option is not enabled.

[ankar84]

Same case, and I totally agree with that issue!
Please fix it.

[diegolmello]

That setting is not implemented on the app yet.

[phriedrich]

Note:

With the /api/v1/settings.public endpoint we can get the information, which data are allowed to edit. Some of them we should probably check and use to limit what the user can edit:

• Accounts_AllowPasswordChange
• Accounts_AllowRealNameChange
• Accounts_AllowUserAvatarChange
• Accounts_AllowUserProfileChange
• Accounts_AllowUsernameChange

For example it's also possible that it is not allowed to change the email address or the username.

[devyaniChoubey]

Can I work on it?

[phriedrich]

Sure, would be really nice to have this fixed.

[Prateek93a]

@phriedrich @devyaniChoubey If work is not being done on this, can I take this up?

[phriedrich]

@Prateek93a I'm not working on this, but I don't know if @devyaniChoubey did some work already.

This ticket is also related to #1590, probably both could be fixed with one PR.

[Prateek93a]

@phriedrich Yes, #1590 will also be fixed in the similar way. In the same PR, all the above mentioned permissions can be checked and implemented accordingly. Thanks
@devyaniChoubey Are you working on this? If not, can I take it up?

[devyaniChoubey]

@Prateek93a Yes I am working on it. I will soon create a PR.I will try to do it by today.

[Prateek93a]

@devyaniChoubey Ok, Great.

[phriedrich]

@devyaniChoubey Any updates on this?

[phriedrich]

This has been solved with the mentioned PR.

Many thanks to everyone involved, especially @tanmoyopenroot and @diegolmello!