Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App does not prompt user to enter password for password protected channels #2258

Closed
joernal opened this issue Jul 8, 2020 · 6 comments · Fixed by #2514
Closed

App does not prompt user to enter password for password protected channels #2258

joernal opened this issue Jul 8, 2020 · 6 comments · Fixed by #2514

Comments

@joernal
Copy link

joernal commented Jul 8, 2020

  • Your Rocket.Chat Experimental app version: 4.6.4
  • Your Rocket.Chat server version: 3.1.1
  • Device (or Simulator) you're running with: iPhone 11 (iOS 13.5 - Simulator)

App does not prompt user for password when joining password-protected channels. User is unable to join the room with the following response (/api/v1/channels.join):

{ "success": false, "error": "Invalid Room Password [error-code-invalid]", "errorType": "error-code-invalid", "details": { "method": "joinRoom" } }

Simulator Screen Shot - iPhone 11 - 2020-07-08 at 13 22 23

@diegolmello
Copy link
Member

@joernal Yeah, it's not implemented yet.
Let me know if you want to contribute.
Thanks for reporting.

@imrishabh18
Copy link
Contributor

Hi @diegolmello , I am quite new to react-native. Can you guide me to resolve this issue? 😀

@djorkaeffalexandre
Copy link
Collaborator

Hey @imrishabh18,
You should implement something like a text input to enter the join code of protected rooms, and send this code on the join method like the documentation explains https://docs.rocket.chat/api/rest-api/methods/channels/join.
Remember that should appear only if the room needs a join code.
Thanks.

@djorkaeffalexandre
Copy link
Collaborator

This is how it looks like on our web client:
Screen Shot 2020-09-16 at 9 19 33 AM

@joernal
Copy link
Author

joernal commented Sep 16, 2020

Hi @djorkaeffalexandre,

I implemented something similar to the web experience.
If it's something similar to what you're looking for, I'd be happy to open a PR for it (and possibly coordinate with @imrishabh18).

Simulator Screen Shot - iPhone 11 - 2020-09-16 at 15 06 39

@djorkaeffalexandre
Copy link
Collaborator

Hi @joernal, it looks good!
Feel free to open a PR, it would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants