Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consecutive uploads are failing with 4.13.0 #2733

Closed
jacotec opened this issue Dec 22, 2020 · 13 comments · Fixed by #2738
Closed

Consecutive uploads are failing with 4.13.0 #2733

jacotec opened this issue Dec 22, 2020 · 13 comments · Fixed by #2738
Assignees
Labels

Comments

@jacotec
Copy link
Contributor

jacotec commented Dec 22, 2020

Description:

After opening the app I can do one upload (photo, voice message etc.) into a chat. Every following upload does not work, the "Uploading ..." message at the top of the chat stays forever. Leaving the chat and rejoining it gives the same issue, in this case the banner mentions that the upload has failes, a retry gives the same issue (no upload happening).

The app must be force closed to re-enable uploads

Environment Information:

  • Rocket.Chat Server Version: 3.9.3
  • Rocket.Chat App Version: 4.13.0
  • Device Name: iPhone 11 Pro Max
  • OS Version: 14.3

Steps to reproduce:

  1. Join any chat
  2. Upload an attachment (photo, video) or record a voice message
  3. The upload works fine
  4. Upload another attachment
  5. The "Uploading ..." banner stays forever and the upload does not work anymore
  6. The app must be force-closed and re-opened to allow another upload, the issue continues then (so also in this case you can do only one upload)

Expected behavior:

Any number of uploads should work

Actual behavior:

See description above

Additional context:

@AmatorPhasma
Copy link

Same here:

Rocket.Chat Server Version: 3.9.3
Rocket.Chat App Version: 4.13.0
Device Name: iPad (Gen. 7)
OS Version: 14.3

also other apps can not share data to Rocket.Chat app anymore.
For example: Photo and Safari.
After selecting Rocket.Chat as share destination a empty dialog opens.

@yash-rajpal
Copy link
Member

Seems like a bug on ios version. I tried on Android device and was able to upload multiple image one after another without any issues.

@diegolmello diegolmello self-assigned this Dec 22, 2020
@AmatorPhasma
Copy link

Seems like a bug on ios version. I tried on Android device and was able to upload multiple image one after another without any issues.

Had some checks here:

iOS 14.2 + App 4.12.1 = works
iOS 14.3 + App 4.12.1 = works

iOS 14.2 + App 4.13.0 = dosen't work
iOS 14.3 + App 4.13.0 = dosen't work

And yes no share problems on Android 7,8,9 (no version 10 available for me)

@diegolmello
Copy link
Member

I'll take a look and release a 4.13.1 when fixed.

@AmatorPhasma
Copy link

I'll take a look and release a 4.13.1 when fixed.

Thank you for the fast response!

@diegolmello
Copy link
Member

@jacotec @AmatorPhasma #2738 fixes this issue, but there's not enough time to make a patch on App Store.
If you have a whitelabeled app and can't wait, apply the PR changes manually.
I'm going to create a patch as first thing on 2021.

@jacotec
Copy link
Contributor Author

jacotec commented Dec 22, 2020

@diegolmello I'll check the fix and will report back. Thanks for your fast fix! :-)

@jacotec
Copy link
Contributor Author

jacotec commented Dec 22, 2020

I can confirm your fix solves the issue!

@AmatorPhasma
Copy link

@jacotec @AmatorPhasma #2738 fixes this issue, but there's not enough time to make a patch on App Store.
If you have a whitelabeled app and can't wait, apply the PR changes manually.
I'm going to create a patch as first thing on 2021.

Can I ask you carefully if there is an ETA for this Patch?

@diegolmello
Copy link
Member

@AmatorPhasma It's live on Google Play already.
It's waiting for review on App Store.

@jacotec
Copy link
Contributor Author

jacotec commented Jan 6, 2021

@diegolmello Ahm, did I overlook something? I'm also waiting for the 4.13.1 as there are a couple of issues fixed to build my 4.13 app version, but I don't see anything in the relases here. If it's already waiting for review why can't I see the release here?

@diegolmello
Copy link
Member

It's because Apple's review is a process bottleneck.
We have to wait for their approval before starting other tasks (GH release, merge master, docs, etc), because Apple can reject us and all work is going to be lost.

@jacotec
Copy link
Contributor Author

jacotec commented Jan 6, 2021

OK, I did not know that you'll merge after the review ;-) Good point! (And agree regarding the bottleneck)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants