Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dramatically low perornance after visiting Files screen #5420

Closed
Lao-Ax opened this issue Dec 20, 2023 · 2 comments · Fixed by #5475
Closed

Dramatically low perornance after visiting Files screen #5420

Lao-Ax opened this issue Dec 20, 2023 · 2 comments · Fixed by #5475

Comments

@Lao-Ax
Copy link
Contributor

Lao-Ax commented Dec 20, 2023

Description:

The app starts performing dramatically slow when you visit list of files in direct messages with somebody or in channel\team.
We found out that it started in version 40. PR #5076 is the reason. To be more specific, there are two components:

app/containers/message/Image.tsx which uses
app/containers/message/Components/BlurComponent/index.tsx

If you delete the second one from rendering in Image, then there is no issue (and looks like the core functionality is still in place). I stopped digging dipper for now.

Please note that the issue is more 'observalbe' on android devices. :)

Environment Information:

  • Rocket.Chat Server Version: 6.4
  • Rocket.Chat App Version: 4.44.0, 4.43.0, 4.42.0, 4.41.0, 4.40.0
  • Device Name: Android 9 Huawei P10; Android 12 Google Pixel 3A XL
  • OS Version: Android 9 Huawei P10; Android 12 Google Pixel 3A XL

Steps to reproduce:

  1. Go to a direct chat with somebody where a lot of images were shared.
  2. Just use the app a bit: go back; observe your chats

Expected behavior:

The app performs as well as on version 39

Actual behavior:

The app work very slow. All animations and lists glitch.

@reinaldonetof
Copy link
Contributor

If you delete the second one from rendering in Image, then there is no issue. I stopped digging dipper for now.

Please note that the issue is more 'observalbe' on android devices. :)

Nice catch, @Lao-Ax

Thanks for your support. We will investigate more.

@diegolmello
Copy link
Member

@reinaldonetof We should remove blur from Android or find another way.

Kureev/react-native-blur#395
Kureev/react-native-blur#368
Kureev/react-native-blur#365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants