From e13f77a2797d51cb738b795a58154d5479b15524 Mon Sep 17 00:00:00 2001 From: Neil Agarwal Date: Mon, 16 Mar 2020 19:30:01 +0530 Subject: [PATCH 1/3] [FIX] README: Switch to npx rather than globally installing react-native-cli The getting started guide on react-native docs also has a warning to not install react-native-cli globally as we'd have to manually update the package whenever we run this. Use npx rather which automatically does this for us, see: https://medium.com/@maybekatz/introducing-npx-an-npm-package-runner-55f7d4bd282b --- README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 392aa07009..d720598b28 100644 --- a/README.md +++ b/README.md @@ -56,16 +56,15 @@ Follow the [React Native Getting Started Guide](https://facebook.github.io/react ```bash $ git clone git@github.com:RocketChat/Rocket.Chat.ReactNative.git $ cd Rocket.Chat.ReactNative - $ yarn global add react-native-cli $ yarn ``` - Run application ```bash - $ react-native run-ios + $ npx react-native run-ios ``` ```bash - $ react-native run-android + $ npx react-native run-android ``` ### Running single server From d7258ab30edfa942dead1ce114a7cdc5c6a82b62 Mon Sep 17 00:00:00 2001 From: Diego Mello Date: Tue, 17 Mar 2020 17:00:28 -0300 Subject: [PATCH 2/3] Remove react-native from ci --- .circleci/config.yml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 579d126df0..7935b86a44 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -190,11 +190,6 @@ jobs: name: Restore NPM cache key: node-modules-{{ checksum "yarn.lock" }} - - run: - name: Install React Native CLI - command: | - npm i -g react-native-cli - - run: name: Install NPM modules command: | @@ -305,12 +300,6 @@ jobs: set +e nvm install 8 - - run: - name: Install NPM modules - command: | - yarn global add react-native react-native-cli - yarn - - run: name: Update Fastlane command: | From af7bfc6c1b1b5f2d69ebaef3b458820bb84876cc Mon Sep 17 00:00:00 2001 From: Diego Mello Date: Tue, 17 Mar 2020 17:29:47 -0300 Subject: [PATCH 3/3] Fix ci --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index b9253271c5..2b9fba2ede 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -300,8 +300,8 @@ jobs: set +e nvm install 8 - - run: - name: Install NPM modules + - run: + name: Install NPM modules command: | yarn