Merge 4.13.0 into master #2728
Merged
Merge 4.13.0 into master #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [WIP] New Action Sheet * [NEW] Header Indicator * [IMPROVEMENT] Header Logic * [NEW] Use EventEmitter to show ActionSheet for while * [FIX] Animation * [IMPROVEMENT] Use provider * [FIX] Add callback * [FIX] Message Actions * [FIX] Add MessageActions icons * [NEW] MessageErrorActions * [IMPROVEMENT] OnClose * [FIX] Adjust height * [FIX] Close/Reopen * [CHORE] Remove react-native-action-sheet * [CHORE] Move ActionSheet * [FIX] Reply Message * [IMPROVEMENT] Hide ActionSheet logic * [WIP] Custom MessageActions Header * [IMPROVEMENT] MessageActions Header * [IMPROVEMENT] Enable Scroll * [FIX] Scroll on Android * Move to react-native-scroll-bottom-sheet * Stash * Refactor actions * Revert some changes * Trying react-native-modalize * Back to HOC * ActionSheet style * HOC Header * Reaction actionSheet * Fix messageBox actions * Fix add reaction * Change to flatListProps * fix modalize android scroll * Use react-native-scroll-bottom-sheet * [NEW] BottomSheet dismissable & [FIX] Android not opening * [NEW] Show emojis based on screen width * [WIP] Adjust to content height * [IMPROVEMENT] Responsible * [IMPROVEMENT] Use alert instead actionSheet at NewServerView * [FIX] Handle tablet cases * [IMPROVEMENT] Remove actionSheet of RoomMembersView * [IMPROVEMENT] Min snap distance when its portrait * [CHORE] Remove unused Components * [IMPROVEMENT] Remove duplicated add-reaction * [IMPROVEMENT] Refactor Icon Package * [IMPROVEMENT] Use new icons * [FIX] Select message at MessageActions before getOptions * [FIX] Custom header height * [CHORE] Remove patch & [FIX] Tablet bottom sheet * [FIX] Use ListItem height to BottomSheet Height * Some fixes * [FIX] Custom MessageActions header * [FIX] Android height adjust * [IMPROVEMENT] Item touchable & [FIX] Respect pin permission * [IMPROVEMENT] More than one snap point * some size fixes * improve code * hide horizontal scroll indicator * [FIX] Focus MessageBox on edit message * [FIX] Ripple color * [IMPROVEMENT] Backdrop must keep same opacity after 50% of the screen * [TEST] Change animation config * [IMPROVEMENT] BackHandler should close the ActionSheet * [CHORE] Add react-native-safe-area-context * [FIX] Provide a bottom padding at notch devices * [IMPROVEMENT] Improve backdrop input/output range * [FIX] Weird Android Snap behavior * [PATCH] React-native-scroll-bottom-sheet * [CI] Re-run build * [FIX] Landscape android * [IMPROVEMENT] Cover 50% of the screen at the landscape mode * [FIX] Adjust emoji content to width size * [IMPROVEMENT] Use hooks library * [IMPROVEMENT] Close the actionSheet when orientation change * deactivate safe-area-context for while * [REVERT] Re-add react-native-safe-area-context (3.0.2) * [IMPROVEMENT] Use focused background * [TESTS] E2E Tests updated to new BottomSheet * [NEW] Add cancel button * [FIX] Cancel button at android * [IMPROVEMENT] Use cancelable bottom sheet at room members view * [IMPROVEMENT] Use better function names * [IMPROVEMENT] Use getItemLayout * [FIX][TEMP] Animation * Review * Build * Header keyExtractor * Rename function * Tweak animation * Refactoring * useTheme * Refactoring * TestIDs * Refactor * Remove old lib Co-authored-by: Diego Mello <diegolmello@gmail.com>
Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com>
Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com>
Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
* [WIP] Use rest instead methodCall * [WIP] Some method calls using wrapper * [WIP] Wrap all necessary methodCalls * fix Co-authored-by: Diego Mello <diegolmello@gmail.com>
* [IMPROVEMENT] Mark a thread as read * Use methodCallWrapper * Check server version Co-authored-by: Diego Mello <diegolmello@gmail.com>
… properties (#2232) Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
* [NEW] MessageBox: Expo-av audio recorder * Refactor MessageBox to accommodate recording button even when recording * Rename Recording.js -> RecordAudio.js as we could implement video recording in the future * RecordAudio: Introduce cancel and send buttons * RecordAudio: Introduce recorderBusy state, refactor MessageBox, remove useless SafeAreaView * RecordAudio: Better audio quality 🎉, stop recording on unmount * RecordAudio: Use FileSystem from expo-file-system instead of RNFetchBlob * chore: flush out react-native-audio * fix(MessageBox): bring back some missed styles during refactor * refactor(RecordAudio): use class component * refactor(RecordAudio): recorder busy to class property, styling changes * recorder initialisation changes * fix(RecordAudio): missing await in isRecordingPermissionGranted * fix(RecordAudio): set isRecording = false on cancel/finish, refactor perms Co-authored-by: Diego Mello <diegolmello@gmail.com>
* Change drawer icon * Removed iOS variation * Patch to react-navigation-header-buttons... easier to patch then to overwrite its behaviour :( * Correctly position title * Header subtitle * Layout * Alignment * RoomView header * Renamed RoomHeaderLeft to LeftButtons * RoomView back button * Search icon on RoomView * Refactor * Fix header on tablet * Fix search messages close button on tablet * Search key command * Network status on RoomView header subtitle * Update tests * Scale content * SearchBox cancel color
Co-authored-by: Diego Mello <diegolmello@gmail.com>
… Share Extension (#2251)
* [FIX] Check if exists scroll ref * Remove scrollTo Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
#2255) Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
…ndroid) (#2624) * wip: Android SSL Pinning * Use own SSLPinningModule * wip: Use Rocket.Chat own react-native * wip: Fresco Images using custom OkHttpClient * wip: react-native-webview onReceivedClientCertRequest * feat: Save Images of a SSL Pinning protected server * chore: SSLPinning package as a interface to iOS & Android implementations * chore: update glide * feat: load images under a client ssl certificate protected server * chore: remove patch * feat: Audio & Video under a SSL Client protected server * fix: Unpin certificate when change server * feat: Fast Image as a patch * chore: update fast-image * Fix merge Co-authored-by: Diego Mello <diegolmello@gmail.com>
* room roles * handle owner * endpoints * Leader and Moderator * Remove user from room * stash ignore * Add subscription.ignored column * ignore user * Fix icons * I18n * Minor i18n fixes * Direct Message and open action sheet after a normal tap * Fix icon * stash isIgnored * isManualUnignored message * Fix update * Ignored * Mute, moderator, leader, owner, remove from room * ignore * Tests * pt-BR * Update pods * Apply requested changes * Add RC version on requests
* wip: RTL (iOS) * wip: RTL (Android) * wip: reload bundle when change between RTL languages * fix: Stack Animation on Android * fix: update snapshot * fix: Swipe Room Actions in RTL mode * fix: snapshots * Move isRTL to i18n * Fix styling * Update tests * Update pods Co-authored-by: Diego Mello <diegolmello@gmail.com>
* Replace keyboard libs for react-native-ui-lib * Apply Jitsi branch * Require keyboard on bundle * Update ui-lib * chore: update deps Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
) * Adding joinCode parameter Co-authored-by: Vitor Leal <vitor_leal2201@hotmail.com> Co-authored-by: Fernando Aguilar <fernando.aguilar@hotmail.com.br> * Insert join code input Signed-off-by: Vitor.Leal <vitor_leal2201@hotmail.com> * Add joinCode field on db Signed-off-by: Vitor.Leal <vitor_leal2201@hotmail.com> * Add label i18 pt-br and en-us Signed-off-by: Vitor.Leal <vitor_leal2201@hotmail.com> * Add insert join code text Signed-off-by: Vitor.Leal <vitor_leal2201@hotmail.com> * Fix atribute name Signed-off-by: Vitor.Leal <vitor_leal2201@hotmail.com> * Add join text Signed-off-by: Vitor.Leal <vitor_leal2201@hotmail.com> Co-authored-by: Daniel Maike <danmke@hotmail.com> Co-authored-by: Fernando Aguilar <fernando.aguilar@hotmail.com.br> * Fix attributes joinCode, joinCodeRequired and pass attribute param in navigation Signed-off-by: Daniel Maike <danmke@hotmail.com> Co-authored-by: Vitor Leal <vitor_leal2201@hotmail.com> * Fixing attribute joinCodeRequired pass to goRoom Signed-off-by: Daniel Maike <danmke@hotmail.com> * Changed textinput style Signed-off-by: Daniel Maike <danmke@hotmail.com> Co-authored-by: Vitor Leal <vitor_leal2201@hotmail.com> * Delete not necessary attribute Signed-off-by: Daniel Maike <danmke@hotmail.com> * Fixing input style Co-authored-by: Vitor Leal <vitor_leal2201@hotmail.com> * Undo unncessary changes * use a join code modal * tests: e2e tests to join protected channel * fix: undo unnecessary change * tests: cancel join code * Remove some tests * Minor fixes Co-authored-by: Vitor Leal <vitor_leal2201@hotmail.com> Co-authored-by: Fernando Aguilar <fernando.aguilar@hotmail.com.br> Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com> Co-authored-by: youssef-md <emaildeyoussefmuhamad@gmail.com> Co-authored-by: Diego Mello <diegolmello@gmail.com>
* Arabic language setup * Added arabic translation * Arabic translation Proofreading Co-authored-by: Diego Mello <diegolmello@gmail.com>
* feat(i18n): add some missing strings and improve some translation * fix: add missing server version Co-authored-by: Diego Mello <diegolmello@gmail.com>
* 1689 - missing user name for status messages * 1689 - missing user name for status messages. Fixed broken e2e test "should pin message". * Minor tweak * Remove center style * Small refactor on User * Remove toLowerCase * Update tests Co-authored-by: Diego Mello <diegolmello@gmail.com>
* fix: filename on react-native-image-crop-picker * fix: use rn-fetch-blob to upload files * fix: FileUpload as a service * fix: cancel upload on iOS * fix: file upload from share extension Co-authored-by: Diego Mello <diegolmello@gmail.com>
* improve white labelling for Android * Move application ID to gradle properties * Fix CI * Point foss sufix to main app * Use npx on android-whitelabel script Co-authored-by: Diego Mello <diegolmello@gmail.com>
* Persist highest value on subscription.roomUpdatedAt * Update tests Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
* Fix main jitsi * Fix iOS * Clear build.gradle cache * Don't restore gradle * cache is back * Use master * Point to react-native-jitsi-meet#master
* Duplicated target and changed Bridging Header * Display name * Unnecessary dumb swift file removed * Buildable name * Reorder Info.plist * Rename Official target's bundle id * Ignore .mobileprovision * Fix provisioning of official app * Starting signing * stash fastfile * starting official ci iOS * Uncomment Fastfile keychain * Fix CI config * allowProvisioningUpdates * Changing AppIcon and Splash Screen * Remove unnecessary folder inside of Images.xcassets * Reorder notificationservice and shareextension plists * Fix signing * Manual signing style for official * Split official signing * Update project provisioning * Use ENV as profile * Output match * Keys * TestFlight refactor * Setting up android * android-official-play-build job * Start removing unnecessary fastlane tasks on Android * Trying to refactor Android jobs * android-env * Remove foss build for now * Fork * Fix if conditions * Fix push * ios-build command * Rename Android builds * Upload dSYMs * Refactoring workflow * Reorder upload-to-testflight * upload-to-google-play-beta command * Fix ci * Fix android fork build * Fix keystore * Fix options on fastlane android * Fix keystore * Check isOfficial on iOS * Check isOfficial on db * Remove unused imports * Database names on Android * Tag fix * Minor fixes * Set IS_OFFICIAL on CI * Fix detox * follow review suggestions Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Typo Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
* Move build_fork to the end * Rename release to build_experimental
…es (#2726) * Remove sequential empty spaces from Markdown preview * Use Markdown preview on RepliedThread
# Conflicts: # .circleci/config.yml # __tests__/__snapshots__/Storyshots.test.js.snap # android/app/build.gradle # android/app/src/debug/AndroidManifest.xml # android/app/src/debug/java/chat/rocket/reactnative/ReactNativeFlipper.java # android/app/src/main/AndroidManifest.xml # android/app/src/main/assets/fonts/custom.ttf # android/app/src/main/java/chat/rocket/reactnative/MainApplication.java # android/app/src/main/res/values-night/colors.xml # android/app/src/main/res/values/colors.xml # android/app/src/main/res/values/strings.xml # android/app/src/main/res/values/styles.xml # android/app/src/play/AndroidManifest.xml # android/app/src/play/java/chat/rocket/reactnative/Encryption.java # android/build.gradle # android/fastlane/Fastfile # android/gradle.properties # android/settings.gradle # app/actions/server.js # app/constants/colors.js # app/constants/environment.js # app/containers/ActionSheet/styles.js # app/containers/Button/index.js # app/containers/EmojiPicker/styles.js # app/containers/List/ListIcon.js # app/containers/List/ListItem.js # app/containers/MessageActions/Header.js # app/containers/MessageBox/EmojiKeyboard.js # app/containers/MessageBox/index.js # app/containers/MessageBox/styles.js # app/containers/ReactionsModal.js # app/containers/TextInput.js # app/containers/Toast.js # app/containers/markdown/index.js # app/containers/message/Content.js # app/containers/message/Message.js # app/containers/message/RepliedThread.js # app/containers/message/User.js # app/containers/message/index.js # app/containers/message/styles.js # app/i18n/index.js # app/i18n/locales/de.js # app/i18n/locales/en.js # app/i18n/locales/es-ES.js # app/i18n/locales/fr.js # app/i18n/locales/it.js # app/i18n/locales/ja.js # app/i18n/locales/nl.js # app/i18n/locales/pt-BR.js # app/i18n/locales/ru.js # app/i18n/locales/zh-CN.js # app/i18n/locales/zh-TW.js # app/lib/database/index.js # app/lib/database/model/Subscription.js # app/lib/database/model/migrations.js # app/lib/database/schema/app.js # app/lib/methods/helpers/mergeSubscriptionsRooms.js # app/lib/methods/sendFileMessage.js # app/lib/methods/subscriptions/rooms.js # app/lib/rocketchat.js # app/lib/selection.json # app/presentation/RoomItem/Actions.js # app/presentation/RoomItem/RoomItem.js # app/presentation/RoomItem/Touchable.js # app/presentation/RoomItem/UpdatedAt.js # app/presentation/RoomItem/index.js # app/presentation/RoomItem/styles.js # app/presentation/TextInput.js # app/presentation/UnreadBadge/getUnreadStyle.js # app/presentation/UnreadBadge/getUnreadStyle.test.js # app/sagas/login.js # app/sagas/selectServer.js # app/stacks/InsideStack.js # app/utils/navigation/animations.js # app/utils/room.js # app/views/AttachmentView.js # app/views/DirectoryView/index.js # app/views/LanguageView/index.js # app/views/NewServerView/index.js # app/views/OnboardingView/styles.js # app/views/PickerView.js # app/views/RoomActionsView/index.js # app/views/RoomActionsView/styles.js # app/views/RoomInfoEditView/styles.js # app/views/RoomMembersView/index.js # app/views/RoomView/List.js # app/views/RoomView/index.js # app/views/ShareListView/index.js # app/views/ShareListView/styles.js # app/views/ShareView/Preview.js # app/views/ThreadMessagesView/Item.stories.js # app/views/ThreadMessagesView/NoDataFound.js # app/views/VisitorNavigationView.js # app/views/WithoutServersView.js # app/views/WorkspaceView/styles.js # e2e/data.js # e2e/data/data.cloud.js # e2e/data/data.docker.js # e2e/helpers/data_setup.js # e2e/tests/init.js # e2e/tests/room/02-room.spec.js # e2e/tests/room/03-roomactions.spec.js # ios/LaunchScreen.storyboard # ios/NotificationService/Info.plist # ios/Podfile.lock # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Headers/JitsiMeet-Swift.h # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Info.plist # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/JitsiMeet # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/Project/x86_64-apple-ios-simulator.swiftsourceinfo # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/Project/x86_64.swiftsourceinfo # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/arm64-apple-ios.swiftdoc # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/arm64-apple-ios.swiftinterface # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/arm64-apple-ios.swiftmodule # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/arm64.swiftdoc # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/arm64.swiftinterface # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/arm64.swiftmodule # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/x86_64-apple-ios-simulator.swiftdoc # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/x86_64-apple-ios-simulator.swiftinterface # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/x86_64-apple-ios-simulator.swiftmodule # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/x86_64.swiftdoc # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/x86_64.swiftinterface # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/Modules/JitsiMeet.swiftmodule/x86_64.swiftmodule # ios/Pods/JitsiMeetSDK/Frameworks/JitsiMeet.framework/main.jsbundle # ios/Pods/Local Podspecs/FBLazyVector.podspec.json # ios/Pods/Local Podspecs/FBReactNativeSpec.podspec.json # ios/Pods/Local Podspecs/RCTRequired.podspec.json # ios/Pods/Local Podspecs/RCTTypeSafety.podspec.json # ios/Pods/Local Podspecs/RNFastImage.podspec.json # ios/Pods/Local Podspecs/React-Core.podspec.json # ios/Pods/Local Podspecs/React-CoreModules.podspec.json # ios/Pods/Local Podspecs/React-RCTActionSheet.podspec.json # ios/Pods/Local Podspecs/React-RCTAnimation.podspec.json # ios/Pods/Local Podspecs/React-RCTBlob.podspec.json # ios/Pods/Local Podspecs/React-RCTImage.podspec.json # ios/Pods/Local Podspecs/React-RCTLinking.podspec.json # ios/Pods/Local Podspecs/React-RCTNetwork.podspec.json # ios/Pods/Local Podspecs/React-RCTSettings.podspec.json # ios/Pods/Local Podspecs/React-RCTText.podspec.json # ios/Pods/Local Podspecs/React-RCTVibration.podspec.json # ios/Pods/Local Podspecs/React-callinvoker.podspec.json # ios/Pods/Local Podspecs/React-cxxreact.podspec.json # ios/Pods/Local Podspecs/React-jsi.podspec.json # ios/Pods/Local Podspecs/React-jsiexecutor.podspec.json # ios/Pods/Local Podspecs/React-jsinspector.podspec.json # ios/Pods/Local Podspecs/React.podspec.json # ios/Pods/Local Podspecs/ReactCommon.podspec.json # ios/Pods/Local Podspecs/Yoga.podspec.json # ios/Pods/Manifest.lock # ios/Pods/Pods.xcodeproj/project.pbxproj # ios/Pods/Target Support Files/Pods-NotificationService/Pods-NotificationService-acknowledgements.markdown # ios/Pods/Target Support Files/Pods-NotificationService/Pods-NotificationService-acknowledgements.plist # ios/Pods/Target Support Files/Pods-NotificationService/Pods-NotificationService.debug.xcconfig # ios/Pods/Target Support Files/Pods-NotificationService/Pods-NotificationService.release.xcconfig # ios/Pods/Target Support Files/Pods-RocketChatRN/Pods-RocketChatRN-acknowledgements.markdown # ios/Pods/Target Support Files/Pods-RocketChatRN/Pods-RocketChatRN-acknowledgements.plist # ios/Pods/Target Support Files/Pods-RocketChatRN/Pods-RocketChatRN.debug.xcconfig # ios/Pods/Target Support Files/Pods-RocketChatRN/Pods-RocketChatRN.release.xcconfig # ios/Pods/Target Support Files/Pods-ShareRocketChatRN/Pods-ShareRocketChatRN-acknowledgements.markdown # ios/Pods/Target Support Files/Pods-ShareRocketChatRN/Pods-ShareRocketChatRN-acknowledgements.plist # ios/Pods/Target Support Files/Pods-ShareRocketChatRN/Pods-ShareRocketChatRN.debug.xcconfig # ios/Pods/Target Support Files/Pods-ShareRocketChatRN/Pods-ShareRocketChatRN.release.xcconfig # ios/Pods/Target Support Files/React-Core/ResourceBundle-AccessibilityResources-React-Core-Info.plist # ios/RocketChatRN.xcodeproj/project.pbxproj # ios/RocketChatRN.xcodeproj/xcshareddata/xcschemes/NotificationService.xcscheme # ios/RocketChatRN.xcodeproj/xcshareddata/xcschemes/RocketChatRN.xcscheme # ios/RocketChatRN.xcodeproj/xcshareddata/xcschemes/ShareRocketChatRN.xcscheme # ios/RocketChatRN/Images.xcassets/AppIcon.appiconset/Contents.json # ios/RocketChatRN/Images.xcassets/Icons/logo.imageset/Contents.json # ios/RocketChatRN/Info.plist # ios/ShareRocketChatRN/Info.plist # ios/Shared/RocketChat/Database.swift # ios/custom.ttf # ios/fastlane/Fastfile # package.json # patches/react-native-webview+10.3.2.patch # patches/rn-fetch-blob+0.12.0.patch # react-native.config.js # storybook/stories/Markdown.js # storybook/stories/Message.js # storybook/stories/RoomItem.js # storybook/stories/index.js # yarn.lock
|
This pull request introduces 1 alert and fixes 1 when merging 2b1cbab into 5cc0856 - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments