Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed link opens in same tab #13581

Closed
grahhnt opened this issue Feb 27, 2019 · 5 comments · Fixed by #13637
Closed

Embed link opens in same tab #13581

grahhnt opened this issue Feb 27, 2019 · 5 comments · Fixed by #13637

Comments

@grahhnt
Copy link
Contributor

grahhnt commented Feb 27, 2019

Description:

When someone posts a link it will embed it and if you click the title of the embed it will open in the same tab. The link that was sent was a Spotify Album link

Steps to reproduce:

  1. A channel
  2. Send a link (possibly just spotify or spotify albums)
  3. Click on the title of the embed

Expected behavior:

To open the link in another tab like all the other links

Actual behavior:

Opens in the same tab

Server Setup Information:

  • Version of Rocket.Chat Server: 0.74.3
  • Operating System: CentOS 7
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Disabled
  • NodeJS Version: Docker
  • MongoDB Version: Docker

Additional context

Relevant logs:

@fliptrail
Copy link
Contributor

I would try this today

@bhardwajaditya
Copy link
Contributor

I will solve this by today

@fliptrail
Copy link
Contributor

@granttoday It is opening in a new tab only. Try to update your RocketChat server. If someone else too agrees with I am saying then I guess this issue can be closed.

@bhardwajaditya
Copy link
Contributor

@fliptrail it's an issue. I have fixed it will make a pull request in few minutes. Try clicking on the song link inside the embed.

@fliptrail
Copy link
Contributor

Ok then, go forward with it. I still can't see it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants