Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar for channels use AvatarExternalProviderUrl that's meant for users #17747

Closed
Gandalf-the-Grey opened this issue May 26, 2020 · 5 comments
Closed
Labels
stat: stale Stale issues will be automatically closed if no activity

Comments

@Gandalf-the-Grey
Copy link

Description:

It's great that avatars for channels are added via #3582,
however, if there's an instance that gets users avatars from external provider:
https://somesite.com/api/get_user_avatar/{username}

for channels like #general it tries to get avatar from
https://somesite.com/api/get_user_avatar/{username}
which is obviously unexpected as it's meant for users

@rodrigok
Copy link
Member

@Gandalf-the-Grey we don't have that feature yet, it's planned for version 3.4 (next month) so I didn't get your issue.

@Gandalf-the-Grey
Copy link
Author

Well, I'm running version 3.2.1 and yet, I clearly see the broken image icon next to channel avatar that's trying to open url according to AvatarExternalProviderUrl

Key Value
Hash 485be3b
Date Fri May 1 13:29:46 2020 -0300
Branch HEAD
Version 3.2.1
Author Diego Sampaio
Subject Merge pull request #17506 from RocketChat/release-3.2.1

@rodrigok
Copy link
Member

@Gandalf-the-Grey can you provide a screen shot and inspect the element to check the URL used for the image?

@Gandalf-the-Grey
Copy link
Author

Can't provide screenshot atm, but with AvatarExternalProviderUrl variable set to: https://images.hive.blog/u/{username}/avatar it ends up with:

<img data-src="https://images.hive.blog/u/@general/avatar" src="https://images.hive.blog/u/@general/avatar" alt="@general" class="avatar-image lazy-img">

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stat: stale Stale issues will be automatically closed if no activity label Jul 26, 2020
@github-actions github-actions bot closed this as completed Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: stale Stale issues will be automatically closed if no activity
Projects
None yet
Development

No branches or pull requests

2 participants