Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client files that live outside /client folders. #6046

Closed
33 of 37 tasks
Kiran-Rao opened this issue Feb 15, 2017 · 3 comments
Closed
33 of 37 tasks

Client files that live outside /client folders. #6046

Kiran-Rao opened this issue Feb 15, 2017 · 3 comments
Assignees
@ggazzo @MartinSchoeler
Labels
type: improvement ui/ux

Comments

@Kiran-Rao
Copy link
Contributor

Kiran-Rao commented Feb 15, 2017 •
edited by rodrigok
Loading

Any client-only files that do not live within a client/ folder causes meteor server to reboot rather than a client refresh.

@rodrigok
Related: #6016 (comment)

Packages:

Meteor (I'm not sure we should modify these)

  • meteor-accounts-saml
  • meteor-autocomplete
  • meteor-timesync

Rocketchat

  • rocketchat-autolinker
  • rocketchat-cas
  • rocketchat-colors
  • rocketchat-custom-oauth
  • rocketchat-custom-sounds # admin
  • rocketchat-emoji
  • rocketchat-emoji-emojione
  • rocketchat-favico
  • rocketchat-highlight-words
  • rocketchat-iframe-login
  • rocketchat-logger # antispan.js, logger.coffee
  • rocketchat-markdown
  • rocketchat-mentions
  • rocketchat-slackbridge # slashcommand
  • rocketchat-slashcommands-archiveroom
  • rocketchat-slashcommands-create
  • rocketchat-slashcommands-invite
  • rocketchat-slashcommands-inviteall
  • rocketchat-slashcommands-join
  • rocketchat-slashcommands-kick
  • rocketchat-slashcommands-leave # Should be split into client/server
  • rocketchat-slashcommands-open
  • rocketchat-slashcommands-topic
  • rocketchat-slashcommands-unarchiveroom
  • rocketchat-tooltip
  • rocketchat-ui
  • rocketchat-ui-account
  • rocketchat-ui-admin
  • rocketchat-ui-flextab
  • rocketchat-ui-login
  • rocketchat-ui-master # master
  • rocketchat-ui-message
  • rocketchat-webrtc
  • rocketchat-wordpress

I would say go through the rocketchat-ui- first as they'll benefit the most.
@Kiran-Rao Kiran-Rao mentioned this issue Feb 16, 2017
Merged
@engelgabriel engelgabriel added this to the 0.53.0 milestone Feb 22, 2017
This was referenced Feb 25, 2017
Merged
Merged
Merged
Merged
Merged
Merged
@engelgabriel engelgabriel modified the milestones: 0.54.0, 0.53.0 Mar 2, 2017
@engelgabriel engelgabriel modified the milestones: 0.54.0, 0.55.0 Mar 22, 2017
@MartinSchoeler MartinSchoeler mentioned this issue Apr 3, 2017
Merged
@engelgabriel engelgabriel modified the milestones: 0.55.0, 0.56.0 Apr 13, 2017
@engelgabriel engelgabriel modified the milestones: 0.56.0, 0.57.0 May 9, 2017
@MartinSchoeler MartinSchoeler mentioned this issue May 10, 2017
Merged
@engelgabriel engelgabriel modified the milestones: 0.57.0, 0.58.0 Jun 19, 2017
This was referenced Sep 14, 2017
Merged
Merged
Merged
Merged
@Kiran-Rao
Copy link
Contributor Author

@vcapretz Sure.

I'll watch out for them in the next few days.

@Kiran-Rao Kiran-Rao reopened this Sep 14, 2017
This was referenced Sep 14, 2017
Merged
Closed
Merged
@Kiran-Rao
Copy link
Contributor Author

@vcapretz Can you tag me when these get merged?

@rodrigok rodrigok modified the milestones: 0.60.0, 0.61.0 Dec 21, 2017
@rodrigok rodrigok modified the milestones: 0.61.0, 0.61.1 Jan 22, 2018
@rodrigok rodrigok modified the milestones: 0.61.1, 0.63.0 Feb 13, 2018
@engelgabriel engelgabriel modified the milestones: 0.63.0, 0.65.0 May 5, 2018
@ggazzo ggazzo modified the milestones: 0.65.0, 0.67.0 Jun 26, 2018
@ggazzo ggazzo added the ui/ux label Jun 26, 2018
@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 20, 2018
@theorenck theorenck modified the milestones: 0.68.0, Short-term Jul 31, 2018
@Kiran-Rao Kiran-Rao reopened this Oct 5, 2018
@theorenck theorenck removed this from the Short-term milestone Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggazzo ggazzo

@MartinSchoeler MartinSchoeler

Labels
type: improvement ui/ux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@rodrigok @Kiran-Rao @engelgabriel @theorenck @ggazzo @vcapretz @MartinSchoeler