Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lift rate limit on createDirectMessage for bots #7302

Closed
jangmarker opened this issue Jun 21, 2017 · 2 comments · Fixed by #7326
Closed

Lift rate limit on createDirectMessage for bots #7302

jangmarker opened this issue Jun 21, 2017 · 2 comments · Fixed by #7326
Assignees
@graywolf336
Labels
feat: hubot type: improvement
Milestone
0.58.0

Comments

@jangmarker
Copy link
Contributor

jangmarker commented Jun 21, 2017 •
edited
Loading

Rocket.Chat Version: 0.55.1
Running Instances: 1
DB Replicaset OpLog: Disabled
Node Version: v4.8.0

In #5200 the rate limit on sendMessage got lifted for bots. However, if a bot wants to send a lot of direct messages at the same time it also needs createDirectMessage to not have a rate limit (the Hubot adapter for instance uses createDirectMessage to find the correct room).
@jangmarker
Copy link
Contributor Author

@graywolf336 I've created a patch in #7326.

@graywolf336
Copy link
Contributor

Hi @jangmarker, I have reviewed your pull request and requested some changes. Thanks for the pull request!

@jangmarker jangmarker mentioned this issue Jul 25, 2017
Merged
@rodrigok rodrigok added this to the 0.58.0 milestone Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graywolf336 graywolf336

Labels
feat: hubot type: improvement
Projects
None yet
Milestone
0.58.0
Development

Successfully merging a pull request may close this issue.

[NEW] Do not rate limit bots on createDirectMessage jangmarker/Rocket.Chat
4 participants
@rodrigok @graywolf336 @jangmarker @MartinSchoeler