Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update steffo:meteor-accounts-saml #9545

Closed
engelgabriel opened this issue Jan 30, 2018 · 11 comments
Closed

Update steffo:meteor-accounts-saml #9545

engelgabriel opened this issue Jan 30, 2018 · 11 comments
Assignees
@rodrigok @pierre-lehnen-rc
Milestone
Short-term

Comments

@engelgabriel
Copy link
Member

https://github.com/steffow/meteor-accounts-saml
@engelgabriel engelgabriel added this to the 0.62.0 milestone Jan 30, 2018
@engelgabriel engelgabriel mentioned this issue Jan 30, 2018
Merged
3 tasks
@engelgabriel
Copy link
Member Author

May be needed for #9546

@rodrigok rodrigok modified the milestones: 0.62.0, 0.63.0 Feb 22, 2018
@megamaced
Copy link

Upgraded from 0.61.0 to 0.62.1.. Now my SAML auth is broken.. Config didn't change

RC configured to connect to Microsoft ADFS 2.0

I now get error

Sorry, an annoying error occured
TypeError: profile.nameIDFormat.indexOf is not a function

@arminfelder
Copy link
Contributor

@engelgabriel I updated the steffow meteor-saml package, to hotfix the broken SAML since 0.62:

#10212 -> fix for release candidate
#10210 -> fix for develop
#10209 -> fix for master

@engelgabriel engelgabriel modified the milestones: 0.63.0, 0.65.0 May 5, 2018
@theorenck theorenck modified the milestones: 0.65.0, Short-term Jul 31, 2018
@gerbsen
Copy link
Contributor

gerbsen commented Aug 22, 2018

@arminfelder @engelgabriel We have merged a pull request for encrypted assertions into meteor-accounts-saml do you guys see any chance that our changes make it to develop? if so, what would be the optimal way?

@arminfelder
Copy link
Contributor

@gerbsen RC uses a slightly modified Version of the meteor-accounts-saml lib, which forces you, to merge it manually, which is ugly, but not too hard.

@gerbsen
Copy link
Contributor

gerbsen commented Aug 24, 2018

Thanks for your response @arminfelder This means we need to change this: https://github.com/RocketChat/Rocket.Chat/tree/develop/packages/meteor-accounts-saml ?

@arminfelder
Copy link
Contributor

@gerbsen yes

@gerbsen
Copy link
Contributor

gerbsen commented Aug 29, 2018

And would you consider merging this, i.e. are PRs welcome here?

@arminfelder
Copy link
Contributor

@gerbsen PRs are certainly welcome, but it often takes quite some time get reviewed by someone who is allowed to

@gerbsen gerbsen mentioned this issue Sep 25, 2018
Merged
@tuxcrafter
Copy link

I am using Rocket.Chat 0.74.3 and I am having SLO errors with SAML. When looking at the code I see differences does the latest version of Rocket.Chat have the upstream patches from steffo? Would somebody be willing to help me out: #13831

There is still html body generation in a few places in the code, can this be updated as well to be integrated better?

[root@rocketchat01 packages]# fgrep "<body>" steffo_meteor-accounts-saml.js
  let content = '<html><head><script>window.close()</script></head><body><H1>Verified</H1></body></html>';
    content = `<html><body><h2>Sorry, an annoying error occured</h2><div>${err}</div><a onclick="window.close();">Close Window</a></body></html>`;

@tuxcrafter tuxcrafter mentioned this issue Apr 1, 2019
Open
@pierre-lehnen-rc pierre-lehnen-rc self-assigned this May 29, 2020
@shakalandy shakalandy mentioned this issue Jul 24, 2020
Closed
@geekgonecrazy
Copy link
Contributor

@rodrigok @pierre-lehnen-rc with all of the changes done in SAML is this still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigok rodrigok

@pierre-lehnen-rc pierre-lehnen-rc

Labels
None yet
Projects
None yet
Milestone
Short-term
Development

No branches or pull requests
9 participants
@geekgonecrazy @rodrigok @engelgabriel @gerbsen @theorenck @arminfelder @tuxcrafter @megamaced @pierre-lehnen-rc