Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline code test/test not parsed correctly #9553

Closed
martinvonwittich opened this issue Jan 30, 2018 · 4 comments · Fixed by #9754
Closed

Inline code test/test not parsed correctly #9553

martinvonwittich opened this issue Jan 30, 2018 · 4 comments · Fixed by #9754

Comments

@martinvonwittich
Copy link

Description:

This is a very minor issue, but I've noticed it several times now, and the Rocket.Chat behaviour seems to deviate from several other Markdown interpreters I've tested.

The problem is that Rocket.Chat won't display the following Markdown code correctly:

`test`/`test`

See Steps to reproduce below. I've tried several other Markdown interpreters I've found online, and they all display it correctly:

Server Setup Information:

  • Version of Rocket.Chat Server: 0.60.3
  • Operating System: Debian stretch
  • Deployment Method(snap/docker/tar/etc): tar
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Disabled
  • Node Version: v8.9.3

Steps to Reproduce:

Post this string in Rocket.Chat:

`test`/`test`

Expected behavior:

It should be displayed like this (GitHub does it correctly):

test/test

Actual behavior:

But instead it is displayed like this:

test/`test`

@c0dzilla
Copy link
Contributor

I've made a pull request that's failing a test which is checking exactly what this issue complains about. So wanted to know: is there any particular reason why the regex has been written like this that I might be unaware of? Or should i modify the test?

@TwizzyDizzy
Copy link

Seems to be working for me by now on https://open.rocket.chat ... can you confirm this? :)

Cheers
Thomas

@martinvonwittich
Copy link
Author

Seems to be working for me by now on https://open.rocket.chat ... can you confirm this? :)

Nope, can still reproduce it in https://open.rocket.chat/channel/01test

I typed `test`/`foobar` and RocketChat rendered it as test/`foobar`.

@TwizzyDizzy
Copy link

OK. You're right. I don't know what I did up there, but I was talking rubbish obviously. Sorry for that.

Cheers
Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants