Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA] Store offline messages, and trigger send after online mode #17441

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

shubhsherl
Copy link

@shubhsherl shubhsherl commented Apr 27, 2020

Third PR to integrate PWA functionality in RC.
https://github.com/WideChat/Rocket.Chat/wiki/PWA-features

Changes from the second PR: shubhsherl/Rocket.Chat@rc_pwa_2...shubhsherl:rc_pwa_3

First PR: #17269
Second PR: #17367
Third PR: #17441
Fourth PR: #17493

@rodrigok
Copy link
Member

rodrigok commented Aug 7, 2020

@shubhsherl can you add a screen shot of the visual changes here like the check/clock icons?

@@ -28,20 +27,7 @@ export function executeSendMessage(uid, message) {
});
}

if (message.ts) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to update the ts (on client side) before send it after became online? Otherwise the message can be inserted a long time in the post on the history, doesn't seems to be a good behavior.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed ts issue

@@ -1,5 +1,5 @@
<template name="messageAttachment">
<div class="attachment">
<div class="attachment {{# if temp}}attachment-temp{{/if}}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a screenshot of this UI change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17441 (comment)
The initial blur to indicate that the attachment is not delivered yet.

@@ -151,6 +151,23 @@
{{/unless}}
{{/if}}

{{#with uploading}}
<div class="attachment-upload-progress color-primary-action-color background-component-color {{#if error}}error-background error-border{{/if}}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a screenshot of this UI change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17441 (comment)
The Progress bar below the attachment, within message.

@@ -56,6 +56,15 @@
<div class="sidebar-item__last-message {{#if showUnread }}{{#if lastMessageUnread }} sidebar-item__last-message--unread{{/if}}{{/if}}">
<span class="message-body--unstyled">{{{lastMessage}}}</span>
</div>
{{#if lastMessageSentByUser}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a screenshot of this UI change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubhsherl
Copy link
Author

@rodrigok here is the screenshot of check and clock for messages which are delivered and undelivered respectively.
image

image

@shubhsherl
Copy link
Author

shubhsherl commented Aug 9, 2020

@rodrigok The UI changes for message-attachment
https://vimeo.com/446173998

@engelgabriel
Copy link
Member

Same as #17367 (comment)

We are finishing to migrate to ReactJS, so this will open the opportunity for us to use WatermelonDB.

@rodrigok can you please give more info here?

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants