-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWA] ChatRoom UI improvements for mobile devices #17549
Open
shubhsherl
wants to merge
17
commits into
RocketChat:develop
Choose a base branch
from
shubhsherl:rc_pwa_ui_1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to evaluate the behavior on iOS, as it is different from the Native on Android. |
This was referenced May 20, 2020
This was referenced Jun 6, 2020
@Sing-Li will arrange a meeting between our design teams to review this PR against the GSoC mobile design project and our ReactNative designs. Once we have all aligned, we can move forward with the review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second PR for UI changes https://github.com/WideChat/Rocket.Chat/wiki/PWA-features to integrate for PWA functionality in RC.
The goal of this PR is to make chat rooms on Mobile device to give similar experience as Native App. It adds a header color in chat room, and a search button.
Original:
Changes made in this PR:
Splash Screen: