-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Avoid last admin deactivate itself #22949
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0b3fbc9
avoid last admin to deactivate itself
ostjen a73fb19
cleaner code
ostjen 23bf06a
refact to avoid nesting
ostjen ca309df
lint fix
ostjen 026ce2d
Merge branch 'develop' into lastAdminDeactivateItself
ostjen 507ca2d
revert changes
ostjen dafe09e
Merge branch 'lastAdminDeactivateItself' of github.com:RocketChat/Roc…
ostjen f6f8a59
refact
ostjen 60ae3e9
lint
ostjen dceaafc
countAdmin refact
ostjen 5569bea
created user method + moved code
ostjen 63a720e
removed useless logs + newlines
ostjen 967342f
removed \n
ostjen 75573a3
small changes
9098911
lint
ostjen e6786bf
Merge branch 'develop' into lastAdminDeactivateItself
ostjen 1cb07ee
Update app/lib/server/functions/setUserActiveStatus.js
ostjen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add this check to removing role if role is admin. Some people seem to keep removing the last admin. 🙈