Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Omnichannel source identification fields #23090

Merged
merged 31 commits into from
Sep 24, 2021

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Sep 1, 2021

Proposed changes (including videos or screenshots)

This PR adds new fields to the room schema that aids in the identification of the source that created an Omnichannel room, which can be either via livechat widget, SMS, app, etc.

Issue(s)

Steps to test or reproduce

Further comments

@d-gubert
Copy link
Member Author

d-gubert commented Sep 6, 2021

Due to a dependency on the Apps-Engine version update, we need to merge #22985 first, then this PR will build successfully

@d-gubert d-gubert marked this pull request as ready for review September 6, 2021 19:50
@d-gubert d-gubert requested a review from KevLehman September 6, 2021 19:50
KevLehman
KevLehman previously approved these changes Sep 6, 2021
@KevLehman
Copy link
Contributor

We modified the Widget code to improve identification process for APIs. This PR now requires a new version of the widget, yet to be released.

RocketChat/Rocket.Chat.Livechat#645

@lgtm-com
Copy link

lgtm-com bot commented Sep 10, 2021

This pull request introduces 1 alert when merging aeb56d1 into d03ee51 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Sep 13, 2021

This pull request introduces 1 alert when merging c259591 into 6ab8225 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2021

This pull request introduces 1 alert when merging 13b225d into ae2a5ac - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

KevLehman
KevLehman previously approved these changes Sep 20, 2021
KevLehman
KevLehman previously approved these changes Sep 20, 2021
tiagoevanp
tiagoevanp previously approved these changes Sep 22, 2021
@KevLehman KevLehman merged commit 0f36b36 into develop Sep 24, 2021
@KevLehman KevLehman deleted the new/omnichannel-source-fields branch September 24, 2021 00:08
@sampaiodiego sampaiodiego mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants