-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Display Avatar Preference not hiding avatars on messages #27072
fix: Display Avatar Preference not hiding avatars on messages #27072
Conversation
This same issue happens with a The hide username also. before that, I'm Waiting for the reviewer to check whether it's the right approach to do or not. |
apps/meteor/client/views/room/MessageList/components/Message.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the comment and apply to all cases
Codecov Report
@@ Coverage Diff @@
## develop #27072 +/- ##
===========================================
+ Coverage 45.14% 45.17% +0.02%
===========================================
Files 755 755
Lines 14607 14607
Branches 2085 2085
===========================================
+ Hits 6595 6598 +3
+ Misses 7717 7715 -2
+ Partials 295 294 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Issue(s)
Closes #26741
Steps to test or reproduce
You will able to toggle it, but if it's enabled, messages are rendering along with the user avatar.
Further comments