-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: Restore contextualbar resizable handler #33921
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33921 +/- ##
========================================
Coverage 75.20% 75.20%
========================================
Files 495 495
Lines 21595 21595
Branches 5362 5362
========================================
Hits 16240 16240
Misses 4713 4713
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Proposed changes (including videos or screenshots)
After updating the
re-resizable
package to version6.10.0
the resizable contextualbar handle stoped to being displayed. We found out there are some changes regarding the rendering position of the handles in DOM, so it causes the previous z-index being overridden by the z-index of the contextualbar. In order to solve it, the PR increase the z-index of theResizable
handle.Issue(s)
Steps to test or reproduce
Further comments