Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Restore contextualbar resizable handler #33921

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Nov 8, 2024

Proposed changes (including videos or screenshots)

After updating the re-resizable package to version 6.10.0 the resizable contextualbar handle stoped to being displayed. We found out there are some changes regarding the rendering position of the handles in DOM, so it causes the previous z-index being overridden by the z-index of the contextualbar. In order to solve it, the PR increase the z-index of the Resizable handle.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: b83bd6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.20%. Comparing base (5c3b6b9) to head (a500f20).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33921   +/-   ##
========================================
  Coverage    75.20%   75.20%           
========================================
  Files          495      495           
  Lines        21595    21595           
  Branches      5362     5362           
========================================
  Hits         16240    16240           
  Misses        4713     4713           
  Partials       642      642           
Flag Coverage Δ
unit 75.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33921/
on branch gh-pages at 2024-11-11 21:19 UTC

@dougfabris dougfabris added this to the 7.1.0 milestone Nov 8, 2024
@dougfabris dougfabris marked this pull request as ready for review November 11, 2024 13:55
@dougfabris dougfabris requested a review from a team as a code owner November 11, 2024 13:55
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Nov 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 11, 2024
@kodiakhq kodiakhq bot merged commit b27ecdf into develop Nov 11, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the regression/contextualbar-handler branch November 11, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants