-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly convert plain text in brackets that is not a link #1132
Open
paviad
wants to merge
12
commits into
RocketChat:main
Choose a base branch
from
paviad:fix-links
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signing is not properly detected even after days have gone by. I have signed and rechecked multiple times. |
dougfabris
force-pushed
the
main
branch
4 times, most recently
from
September 15, 2023 19:45
77be55a
to
a97c7f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Properly convert the following:
[Title 1] foo [TItle 2](http://bar.com)
to html<p>[Title 1] foo <a href="http://bar.com">Title 2</a>
[Foo [Bar _emph_ Baz] Waz](http://bar.com)
to html<a href="http://bar.com">Foo [Bar <i>emph</i> Baz] Waz</a>
Issue(s)
Closes #1131
Further comments
Tests included