perf: Avoid re-renders due to PropsContext #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gabriellsh Could you please test it working on Rocket.Chat? Comparing the latest version against this branch via React DevTools profilling would be enough. |
tested, looks way better, thanks! |
tassoevan
force-pushed
the
perf/use-props
branch
from
481a167
to
e56a1dc
Compare
gabriellsh
added a commit
that referenced
this pull request
Mar 11, 2020
…into feat/buttons * 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage: (26 commits) v0.4.0 feat!: CSS-in-JS for modifiers of Box (#164) perf: Avoid re-renders due to PropsContext (#154) feat: useMutableCallback (#156) chore: Add bug report template (#158) feat: Added callback prop for scroll position (#155) fix: Display name and prop types of Throbber component (#148) fix: Changed accordion item title proptype (#151) v0.3.0 fix: actionId on action hooks (#149) v0.2.0 (#150) chore: Tabs Layout (#125) feat: Loading Component (#147) v0.2.0 v0.2.0-alpha.30 fix: Safari not triggering buttons anchors (#146) v0.2.0-alpha.29 bump version (#145) v0.2.0-alpha.28 fix: placeholder transition (#144) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each
Boxconsumes and provides an new plain object value fromPropsContext, that causes pointless re-renderings. Using a single empty object to represent no additional props and component memoization might fix that.