Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select arrow position #157

Merged
merged 5 commits into from
Mar 16, 2020
Merged

fix: Select arrow position #157

merged 5 commits into from
Mar 16, 2020

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Mar 6, 2020

Closes #153
When select is empty, the downward arrow stayed at the wrong position.

image

@tassoevan tassoevan changed the title [FIX] Select arrow Position fix: Select arrow position Mar 6, 2020
@tassoevan tassoevan requested a review from ggazzo March 10, 2020 19:00
@ggazzo ggazzo merged commit 4ef17e0 into develop Mar 16, 2020
@ggazzo ggazzo deleted the fix/emptySelect branch March 16, 2020 22:51
gabriellsh added a commit that referenced this pull request Mar 20, 2020
…into feat/buttons

* 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage:
  v0.5.0
  feat: Tags and Badges (#167)
  fix: Empty space before SelectFiltered placeholder (#171)
  feat: Focus visible (#165)
  feat: Tooltip component (#121)
  v0.4.1
  fix: filteredOptions for options (#169)
  chore: fixed grammer in README (#168)
  fix: Select arrow position for empty selects (#157)
  fix: Build @rocket.chat/css-in-js as ES module (#166)
  chore: Added x48 avatar size (#170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select looks weird without placeholder or value
3 participants