Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Box props #213

Merged
merged 19 commits into from
Apr 28, 2020
Merged

feat: New Box props #213

merged 19 commits into from
Apr 28, 2020

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented Apr 25, 2020

It enables a set of style props to prototype using the Box. In addition, some props were deprecated.

@tassoevan tassoevan requested a review from a team April 26, 2020 06:12
@tassoevan tassoevan marked this pull request as ready for review April 26, 2020 06:42
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks quite good but has some issues
image

@ggazzo ggazzo merged commit b593875 into develop Apr 28, 2020
@ggazzo ggazzo deleted the feat/new-box-props branch April 28, 2020 03:38
ggazzo added a commit that referenced this pull request Apr 28, 2020
…into new/popover_menu

* 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage:
  feat: New Box props (#213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants