Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use dir attribute from documentElement #304

Merged
merged 2 commits into from
Oct 20, 2020
Merged

fix: Use dir attribute from documentElement #304

merged 2 commits into from
Oct 20, 2020

Conversation

tassoevan
Copy link
Collaborator

The selector *:not([dir=rtl]) will style elements even under an ancestor with dir="rtl" if some descendant ancestors don't declare the dir attribute. The current workaround is to just use the attribute at the documentElement, i.e., the html element.

@tassoevan tassoevan added 🐛 Bug Something isn't working 📦 css-in-js labels Oct 20, 2020
@tassoevan tassoevan requested a review from a team October 20, 2020 05:13
@ggazzo ggazzo merged commit f574b8c into develop Oct 20, 2020
@ggazzo ggazzo deleted the fix/rtl branch October 20, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
🐛 Bug Something isn't working 📦 css-in-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo