fix: Sidebar item icon styles #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tassoevan
reviewed
Jul 2, 2021
| @@ -100,7 +100,7 @@ $sidebar-item-color-selected: theme( | |||
| &__wrapper { | |||
| @extend %sidebar-base; | |||
| @include typography.use-with-truncated-text(); | |||
| flex: 1 0 100%; | |||
| flex: 1 0 1%; | |||
There was a problem hiding this comment.
What is happening in this flex basis of 1%?
…into fix/sidebar-icons * 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage: new: ConfirmedProcessPage component (#486)
tassoevan
approved these changes
Jul 6, 2021
gabriellsh
added a commit
that referenced
this pull request
Jul 8, 2021
…t.Fuselage into wizard/server_reg_form * 'new/admin-org-form' of github.com:RocketChat/Rocket.Chat.Fuselage: fix: review chore: loki new: react-hook-form implementation fix: Form component location Mock ResizeObserver on tests new: AwaitingConfirmationPage Component (#491) fix: Sidebar item icon styles (#481) fix: components name fix(fuselage): No preventDefault on PaginatedSelect (#490)
This was referenced Sep 13, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Further comments