Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: No preventDefault on PaginatedSelect #490

Merged
merged 2 commits into from
Jul 6, 2021
Merged

fix: No preventDefault on PaginatedSelect #490

merged 2 commits into from
Jul 6, 2021

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jul 6, 2021 •
edited
Loading

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

The PaginatedSelect was missing the prevent default property, causing the options to close whenever someone clicked the scroll bar.

@MartinSchoeler MartinSchoeler requested a review from a team July 6, 2021 14:26
@tassoevan tassoevan changed the title [FIX] No preventDefault on PaginatedSelect fix(fuselage): No preventDefault on PaginatedSelect Jul 6, 2021
@tassoevan tassoevan merged commit 0ffb736 into develop Jul 6, 2021
@tassoevan tassoevan deleted the fix-prevendefault-paginated-select branch July 6, 2021 20:40
@MartinSchoeler MartinSchoeler changed the title fix(fuselage): No preventDefault on PaginatedSelect fix: No preventDefault on PaginatedSelect Jul 7, 2021
gabriellsh added a commit that referenced this pull request Jul 8, 2021
@gabriellsh
Merge branch 'new/admin-org-form' of github.com:RocketChat/Rocket.Cha…
80c85ed 
…t.Fuselage into wizard/server_reg_form

* 'new/admin-org-form' of github.com:RocketChat/Rocket.Chat.Fuselage:
  fix: review
  chore: loki
  new: react-hook-form implementation
  fix: Form component location
  Mock ResizeObserver on tests
  new: AwaitingConfirmationPage Component (#491)
  fix: Sidebar item icon styles (#481)
  fix: components name
  fix(fuselage): No preventDefault on PaginatedSelect (#490)
This was referenced Sep 13, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinSchoeler @tassoevan