Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fuselage): Empty State Component #572

Merged
merged 15 commits into from
Nov 30, 2021
Merged

feat(fuselage): Empty State Component #572

merged 15 commits into from
Nov 30, 2021

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Nov 17, 2021 •
edited
Loading

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

image

Issue(s)

Further comments

@rique223
feat: Create new "no match for search" fallback component
ffdc990 
I've created a new component that warns the user if their search bears no results for the searched words.
@rique223
Small changes
01e0e1c
@CLAassistant
Copy link

CLAassistant commented Nov 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rique223 rique223 requested a review from a team November 17, 2021 18:53
@ggazzo ggazzo changed the title feat: Fallback Component feat(fuselage): Fallback Component Nov 17, 2021
@ggazzo ggazzo dismissed ujorgeleite’s stale review November 18, 2021 23:00

still a draft but thanks

@ggazzo ggazzo marked this pull request as draft November 18, 2021 23:01
@rique223 rique223 marked this pull request as ready for review November 29, 2021 18:45
@rique223 rique223 requested a review from a team November 29, 2021 18:45
@dougfabris dougfabris force-pushed the app-fallback branch 2 times, most recently from 636049d to bcc31c1 Compare November 29, 2021 19:39
@ggazzo ggazzo changed the title feat(fuselage): Fallback Component feat(fuselage): Empty State Component Nov 30, 2021
dougfabris
dougfabris requested changes Nov 30, 2021
View reviewed changes
Copy link
Member

@dougfabris dougfabris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the loki refs with the old component name

dougfabris
dougfabris previously approved these changes Nov 30, 2021
View reviewed changes
@ggazzo ggazzo merged commit aa22b55 into develop Nov 30, 2021
@ggazzo ggazzo deleted the app-fallback branch November 30, 2021 21:19
ujorgeleite pushed a commit that referenced this pull request Dec 1, 2021
@rique223 @ggazzo
@dougfabris @ujorgeleite
feat(fuselage): Empty State Component (#572)
79a2a88 
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Douglas Fabris <devfabris@gmail.com>
This was referenced Sep 13, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

@ujorgeleite ujorgeleite ujorgeleite left review comments

Assignees
No one assigned
Labels
📦 fuselage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rique223 @CLAassistant @ujorgeleite @dougfabris @ggazzo