Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuselage): Convert mdx to csf #584

Merged
merged 86 commits into from
Jan 19, 2022
Merged

feat(fuselage): Convert mdx to csf #584

merged 86 commits into from
Jan 19, 2022

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Dec 8, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@juliajforesti juliajforesti changed the title Feat/convert mdx to csf feat(fuselage): Convert mdx to csf Dec 8, 2021
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 6, 2022

This pull request introduces 1 alert when merging e1d1974 into 74a67be - view on LGTM.com

new alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 6, 2022

This pull request introduces 1 alert when merging 2b58657 into 74a67be - view on LGTM.com

new alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 7, 2022

This pull request introduces 1 alert when merging 57ddc6a into 0ac4a24 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 7, 2022

This pull request introduces 1 alert when merging bbe180b into f0662eb - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@ggazzo ggazzo force-pushed the feat/convert-mdx-to-csf branch 5 times, most recently from 4a7e892 to c18589d Compare January 7, 2022 19:13
@dougfabris dougfabris marked this pull request as ready for review January 18, 2022 18:34
@ggazzo ggazzo merged commit 238768e into develop Jan 19, 2022
@ggazzo ggazzo deleted the feat/convert-mdx-to-csf branch January 19, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants