chore(di): Remove method ServerLoader.getSettingsService

BREAKING CHANGE: Remove static method ServerLoader.getSettingsService. Use ServerLoader.settings insteadof
tsedio · Dec 23, 2018 · 59ae2b8 · 59ae2b8
1 parent a47a60f
commit 59ae2b8
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 22 deletions.
diff --git a/ISSUE_TEMPLATE.md b/ISSUE_TEMPLATE.md
@@ -1,18 +1,20 @@
 <!-- This template it's just here to help you for write your Issue -->
 
-## Informations
+## Information
 
-Type | Version
----|---
-Bug/Improvement/Question | 4.x
-
-****
+- **Version:** 4.x
+- **Type:** Issue/Story
 
 ## Description
 A few sentences describing the overall goals of the issue.
 
+## Example
+
+```
+import {} from "@tsed/common";
+
+```
 
-## Acceptance criterias
+## Acceptance criteria
 
-- [ ] Example (log, usecase, etc...)
-- [ ] Ts.ED version (bug/question)
+- [ ] Criteria 1
diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md
@@ -2,8 +2,8 @@
 
 ## Informations
 
-Type | Migration
----|---|---
+Type | Breaking change
+---|---
 Feature/Fix/Doc/Chore | Yes/No
 
 ****

diff --git a/packages/common/src/server/components/ServerLoader.ts b/packages/common/src/server/components/ServerLoader.ts
@@ -1,4 +1,4 @@
-import {Deprecated, isClass} from "@tsed/core";
+import {isClass} from "@tsed/core";
 import {InjectorService} from "@tsed/di";
 import * as Express from "express";
 import * as globby from "globby";
@@ -220,14 +220,6 @@ export abstract class ServerLoader implements IServerLifecycle {
     return elseFn();
   };
 
-  /**
-   *
-   */
-  @Deprecated("Removed feature. Use ServerLoader.settings")
-  protected getSettingsService(): ServerSettingsService {
-    return this.settings;
-  }
-
   /**
    * Start the express server.
    * @returns {Promise<any>|Promise}

diff --git a/test/units/server/components/ServerLoader.spec.ts b/test/units/server/components/ServerLoader.spec.ts
@@ -27,8 +27,6 @@ describe("ServerLoader", () => {
     this.useStub = Sinon.stub(this.server.expressApp, "use");
     this.setStub = Sinon.stub(this.server.expressApp, "set");
     this.engineStub = Sinon.stub(this.server.expressApp, "engine");
-    // deprecated
-    this.server.getSettingsService();
   });
 
   after(() => {