chore(mvc): Remove RouterController

BREAKING CHANGE: Remove RouterController. Use ExpressRouter insteadof.
tsedio · Dec 23, 2018 · 62f147b · 62f147b
1 parent 66f0ff0
commit 62f147b
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 39 deletions.
diff --git a/packages/common/src/mvc/index.ts b/packages/common/src/mvc/index.ts
@@ -32,7 +32,6 @@ export * from "./components/LogIncomingRequestMiddleware";
 // services
 export * from "./services/ControllerService";
 export * from "./services/MiddlewareService";
-export * from "./services/RouterController";
 export * from "./services/ExpressRouter";
 export * from "./services/RouteService";
 

diff --git a/packages/common/src/mvc/registries/ControllerRegistry.ts b/packages/common/src/mvc/registries/ControllerRegistry.ts
@@ -1,7 +1,6 @@
 import {TypedProvidersRegistry, ProviderType, GlobalProviders} from "@tsed/di";
 import {ControllerProvider} from "../class/ControllerProvider";
 import {ExpressRouter} from "../services/ExpressRouter";
-import {RouterController} from "../services/RouterController";
 
 // tslint:disable-next-line: variable-name
 export const ControllerRegistry: TypedProvidersRegistry = GlobalProviders.createRegistry(ProviderType.CONTROLLER, ControllerProvider, {
@@ -10,7 +9,6 @@ export const ControllerRegistry: TypedProvidersRegistry = GlobalProviders.create
 
   onInvoke(provider: ControllerProvider, locals, designParamTypes) {
     if (!locals.has(ExpressRouter)) {
-      locals.set(RouterController, new RouterController(provider.router));
       locals.set(ExpressRouter, provider.router);
     }
   }

diff --git a/packages/common/src/mvc/services/RouterController.ts b/packages/common/src/mvc/services/RouterController.ts
diff --git a/test/units/mvc/registries/ControllerRegistry.spec.ts b/test/units/mvc/registries/ControllerRegistry.spec.ts
@@ -1,4 +1,4 @@
-import {ControllerProvider, ExpressRouter, GlobalProviders, ProviderType, RouterController} from "@tsed/common";
+import {ControllerProvider, ExpressRouter, GlobalProviders, ProviderType} from "@tsed/common";
 import {expect} from "../../../tools";
 
 describe("ControllerRegistry", () => {
@@ -13,10 +13,6 @@ describe("ControllerRegistry", () => {
     settings.onInvoke!(this.provider, this.locals, []);
   });
 
-  it("should store RouterController (deprecated)", () => {
-    expect(this.locals.has(RouterController)).to.eq(true);
-  });
-
   it("should store ExpressRouter", () => {
     expect(this.locals.has(ExpressRouter)).to.eq(true);
   });

diff --git a/test/units/mvc/services/RouterController.spec.ts b/test/units/mvc/services/RouterController.spec.ts