From a1db7d7752159f0db35e77bb05eb9da1f1cac010 Mon Sep 17 00:00:00 2001
From: Andreas Stefl <stefl.andreas@gmail.com>
Date: Fri, 8 Nov 2024 17:56:02 +0100
Subject: [PATCH] fix: Drop `removeNeutral` from particle pre-selection in
 Examples (#3830)

I think this is there by accident and propagated to a number of workflows. Neutral particles can convert during event simulation and should be kept. For the post selection it is valid as we do no performance on neutral particles.
---
 Examples/Python/tests/root_file_hashes.txt     | 2 +-
 Examples/Scripts/Python/full_chain_itk.py      | 1 -
 Examples/Scripts/Python/full_chain_itk_Gbts.py | 1 -
 Examples/Scripts/Python/full_chain_odd.py      | 2 --
 Examples/Scripts/Python/full_chain_odd_LRT.py  | 2 --
 Examples/Scripts/Python/hashing_seeding.py     | 1 -
 6 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/Examples/Python/tests/root_file_hashes.txt b/Examples/Python/tests/root_file_hashes.txt
index 2ecf8b57c94e..eb97555e0849 100644
--- a/Examples/Python/tests/root_file_hashes.txt
+++ b/Examples/Python/tests/root_file_hashes.txt
@@ -7,7 +7,7 @@ test_seeding__estimatedparams.root: 69c0e268f9025a0991a212ea2a7f26f53112fecf614b
 test_seeding__performance_seeding.root: 992f9c611d30dde0d3f3ab676bab19ada61ab6a4442828e27b65ec5e5b7a2880
 test_seeding__particles.root: 7855b021f39ad238bca098e4282667be0666f2d1630e5bcb9d51d3b5ee39fa14
 test_seeding__particles_simulation.root: f937a4cc474e80cfbb6eac4384e42e9c5c7ac981fcd6870d624cc898d1a0c006
-test_hashing_seeding__estimatedparams.root: 1ab38fbedeaff1380fc022e2970e6c74163d770613205100bd34c3e88283e387
+test_hashing_seeding__estimatedparams.root: 8daa3f04342c265f32f1608ccc921ab0041686a6280b956f811638ad4328330e
 test_seeding_orthogonal__estimatedparams.root: ca5896ec325daf5c8012291bc454269c61c32fe3d7e33bd1fa3b812826930299
 test_seeding_orthogonal__performance_seeding.root: 60fbedcf5cb2b37cd8e526251940564432890d3a159d231ed819e915a904682c
 test_seeding_orthogonal__particles.root: 7855b021f39ad238bca098e4282667be0666f2d1630e5bcb9d51d3b5ee39fa14
diff --git a/Examples/Scripts/Python/full_chain_itk.py b/Examples/Scripts/Python/full_chain_itk.py
index 51746c127a1f..b5c17278a1ec 100755
--- a/Examples/Scripts/Python/full_chain_itk.py
+++ b/Examples/Scripts/Python/full_chain_itk.py
@@ -67,7 +67,6 @@
             absZ=(0.0 * u.mm, 1.0 * u.m),
             eta=(-4.0, 4.0),
             pt=(150 * u.MeV, None),
-            removeNeutral=True,
         )
         if ttbar_pu200
         else ParticleSelectorConfig()
diff --git a/Examples/Scripts/Python/full_chain_itk_Gbts.py b/Examples/Scripts/Python/full_chain_itk_Gbts.py
index a87f5ca66564..ac9cc8ae8fc7 100755
--- a/Examples/Scripts/Python/full_chain_itk_Gbts.py
+++ b/Examples/Scripts/Python/full_chain_itk_Gbts.py
@@ -62,7 +62,6 @@
             absZ=(0.0 * u.mm, 1.0 * u.m),
             eta=(-4.0, 4.0),
             pt=(150 * u.MeV, None),
-            removeNeutral=True,
         )
         if ttbar_pu200
         else ParticleSelectorConfig()
diff --git a/Examples/Scripts/Python/full_chain_odd.py b/Examples/Scripts/Python/full_chain_odd.py
index fd98f759577f..347e52714eae 100755
--- a/Examples/Scripts/Python/full_chain_odd.py
+++ b/Examples/Scripts/Python/full_chain_odd.py
@@ -269,7 +269,6 @@
                 absZ=(0.0, 1.0 * u.m),
                 eta=(-3.0, 3.0),
                 pt=(150 * u.MeV, None),
-                removeNeutral=True,
             ),
             postSelectParticles=ParticleSelectorConfig(
                 pt=(1.0 * u.GeV, None),
@@ -294,7 +293,6 @@
                     absZ=(0.0, 1.0 * u.m),
                     eta=(-3.0, 3.0),
                     pt=(150 * u.MeV, None),
-                    removeNeutral=True,
                 )
                 if args.ttbar
                 else ParticleSelectorConfig()
diff --git a/Examples/Scripts/Python/full_chain_odd_LRT.py b/Examples/Scripts/Python/full_chain_odd_LRT.py
index 2188bb98d6b2..5cbac847baa6 100644
--- a/Examples/Scripts/Python/full_chain_odd_LRT.py
+++ b/Examples/Scripts/Python/full_chain_odd_LRT.py
@@ -270,7 +270,6 @@
                 absZ=(0.0, 1.0 * u.m),
                 eta=(-3.0, 3.0),
                 pt=(150 * u.MeV, None),
-                removeNeutral=True,
             ),
             postSelectParticles=ParticleSelectorConfig(
                 pt=(1.0 * u.GeV, None),
@@ -295,7 +294,6 @@
                     absZ=(0.0, 1.0 * u.m),
                     eta=(-3.0, 3.0),
                     pt=(150 * u.MeV, None),
-                    removeNeutral=True,
                 )
                 if args.ttbar
                 else ParticleSelectorConfig()
diff --git a/Examples/Scripts/Python/hashing_seeding.py b/Examples/Scripts/Python/hashing_seeding.py
index 3148a03837dc..770c34e51855 100755
--- a/Examples/Scripts/Python/hashing_seeding.py
+++ b/Examples/Scripts/Python/hashing_seeding.py
@@ -211,7 +211,6 @@ def runHashingSeeding(
         preSelectParticles=ParticleSelectorConfig(
             eta=(-eta, eta),
             pt=(150 * u.MeV, None),
-            removeNeutral=True,
         ),
         postSelectParticles=ParticleSelectorConfig(
             pt=(1.0 * u.GeV, None),