Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accuracy formula in the doc doesn't match the one coded #343

Open
LouisAUTHIE opened this issue Aug 19, 2024 · 1 comment
Open

Accuracy formula in the doc doesn't match the one coded #343

LouisAUTHIE opened this issue Aug 19, 2024 · 1 comment

Comments

@LouisAUTHIE
Copy link
Contributor

In the Accuracy documentation, the formula presented is not the one coded in the class.
https://github.com/RubixML/ML/blob/master/src/CrossValidation/Metrics/Accuracy.php

@andrewdalpino
Copy link
Member

andrewdalpino commented Aug 19, 2024

Good observation. The Accuracy Metric scores the predictions differently that the accuracy value computed from the confusion matrix (in Multiclass Breakdown). Specifically the Metric only considers true positives while the Report considers both true positives and negatives. I tried to show the differences by providing the formulas in the docs but they could be wrong - I don't consider myself a mathematician. Perhaps someone with more experience can give it a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants