Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider marking 0.1.5 tag as latest release #27

Closed
chenrui333 opened this issue Jun 7, 2024 · 5 comments
Closed

consider marking 0.1.5 tag as latest release #27

chenrui333 opened this issue Jun 7, 2024 · 5 comments
Assignees
Labels
Release Release

Comments

@chenrui333
Copy link
Contributor

chenrui333 commented Jun 7, 2024

👋 looks like 0.1.5 tag is not the latest, consider mark it as latest and remove the latest tag (which is kind of outdated)

image

relates to Homebrew/homebrew-core#173951

@ccmywish
Copy link
Contributor

ccmywish commented Jun 8, 2024

Hi @chenrui333

I've released the newest version v0.1.6.


Do I have to remove the tag latest? In fact, I'm still using it to provide (in GitHub actions) a stable url for users to always download the real latest precompiled binaries. See: https://github.com/RubyMetric/chsrc/blob/main/.github/workflows/linux-x64.yml#L23-L30

That means,

  1. the binaries in tag latest release and in tag v0.1.6 release are just the totally same.
  2. However, the source code in two releases are not the same, the code in latest release is surely obsolete as you think.

So could you please give me some advice based on your abundant experience? Is there any best practice? Or it just doesn't matter?

@ccmywish
Copy link
Contributor

ccmywish commented Jun 8, 2024

I'm wondering how homebrew work to check updating.

Now the repo has two latest:

  1. tag name v0.1.6: I've set it to Latest via GitHub release page
    image

  2. tag name latest,it's just a name which I used git tag to generate.


So which one will homebrew consider?

@ccmywish ccmywish self-assigned this Jun 8, 2024
@ccmywish ccmywish added the Release Release label Jun 8, 2024
@chenrui333
Copy link
Contributor Author

Do I have to remove the tag latest? In fact, I'm still using it to provide (in GitHub actions) a stable url for users to always download the real latest precompiled binaries.

what you should do is probably like what folks are doing with github actions, so that v1 would be a alias tag to all v1 releases.

because the latest approach would be dangerous for v2 v3 breaking releases.

what do you think?

@ccmywish
Copy link
Contributor

ccmywish commented Jun 9, 2024

Thank you for pointing out the breaking issue.

Although I don't think this command line tool's interface will change, I still appreciate the idea.

I will rename the tag latest to another name like prebuilt or something.

@ccmywish
Copy link
Contributor

Rename to tag pre, and set it to Pre-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Release
Projects
None yet
Development

No branches or pull requests

2 participants