Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move properties unique to individual feats to params table #110

Closed
Ruin0x11 opened this issue Sep 6, 2020 · 0 comments · Fixed by #357
Closed

Move properties unique to individual feats to params table #110

Ruin0x11 opened this issue Sep 6, 2020 · 0 comments · Fixed by #357
Labels
refactoring This requires refactoring existing code

Comments

@Ruin0x11
Copy link
Owner

Ruin0x11 commented Sep 6, 2020

We do this already for items, where iParamX was moved to the params table. But right now unique properties (door difficulty, plant growth state) are set directly on the feat object itself. It would be better to move them into params so it is clear that the properties are unique to that feat type only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring This requires refactoring existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant