Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying render width/height of tile draw layers #39

Closed
Ruin0x11 opened this issue Jul 27, 2020 · 0 comments · Fixed by #224
Closed

Allow specifying render width/height of tile draw layers #39

Ruin0x11 opened this issue Jul 27, 2020 · 0 comments · Fixed by #224
Labels
api Concerns the public API design Concerns the architecture of the engine refactoring This requires refactoring existing code

Comments

@Ruin0x11
Copy link
Owner

For the screenshot feature to work, we'd have to be able to ask the renderer to output an image at the same size as the entire map the player is in. But currently there is no width or height parameter to determine the width and height of the visible area in IDrawLayer:draw(x, y). We should force this method to accept width and height also, without having to use ICoords:get_start_offset().

@Ruin0x11 Ruin0x11 added api Concerns the public API design Concerns the architecture of the engine refactoring This requires refactoring existing code labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Concerns the public API design Concerns the architecture of the engine refactoring This requires refactoring existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant