Fix FastBoot support #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tobias Bieniek <tobias.bieniek@gmail.com>
|
@RuslanZavacky any objections or thoughts on this? |
|
This is working for me, would like to see it merged. Great work @mansona |
…p` to avoid conflicts
|
I'm going to go ahead and merge this as it fixes the issue with FastBoot. If we find better alternatives we can replace this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the implementation aspect of #56 without any changes to the tests. After we get this merged I will update the tests to make sure we're checking fastboot support (which we're not currently doing on master).
Essentially since
v0.8.0fastboot support has been broken because we currently rely on thedocumentto implement the inline implementation. This PR adds a fastboot-specific code-path that now works 🎉