Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binder: cleanup unsafe in unsafe fns warning (E0133) #341

Closed
ojeda opened this issue Jun 3, 2021 · 0 comments · Fixed by #348
Closed

binder: cleanup unsafe in unsafe fns warning (E0133) #341

ojeda opened this issue Jun 3, 2021 · 0 comments · Fixed by #348
Assignees
Labels
• drivers Related to the example drivers in `drivers/`.

Comments

@ojeda
Copy link
Member

ojeda commented Jun 3, 2021

We enabled the warnings in #339 and we would like to move it to hard error, so we need to clean them up.

warning: call to unsafe function is unsafe and requires unsafe block (error E0133)
  --> drivers/android/node.rs:86:20
   |
86 |               inner: SpinLock::new(NodeDeathInner {
   |  ____________________^
87 | |                 dead: false,
88 | |                 cleared: false,
89 | |                 notification_done: false,
90 | |                 aborted: false,
91 | |             }),
   | |______________^ call to unsafe function
@ojeda ojeda added • drivers Related to the example drivers in `drivers/`. prio: high labels Jun 3, 2021
@ojeda ojeda closed this as completed in #348 Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
• drivers Related to the example drivers in `drivers/`.
Development

Successfully merging a pull request may close this issue.

2 participants