Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.6 release tracking ticket #681

Open
2 of 9 tasks
tarcieri opened this issue Sep 19, 2024 · 4 comments
Open
2 of 9 tasks

v0.6 release tracking ticket #681

tarcieri opened this issue Sep 19, 2024 · 4 comments

Comments

@tarcieri
Copy link
Member

tarcieri commented Sep 19, 2024

This is a list of release blockers for crypto-bigint v0.6.0, nearly all of which are final releases of dependencies which are currently in a prerelease state:

@tarcieri tarcieri pinned this issue Sep 19, 2024
@tarcieri
Copy link
Member Author

tarcieri commented Nov 1, 2024

With a prospective MSRV of 1.83 already, and the 2024 edition set to be stabilized in Rust 1.85 on 2025-02-20, I'm wondering if it makes sense to wait for that as well: https://doc.rust-lang.org/edition-guide/rust-2024/index.html

Notably edition bumps are a time where the entire ecosystem makes a more concerted effort to bump MSRV.

@dvdplm
Copy link
Contributor

dvdplm commented Nov 21, 2024

My two cents on this is: don't wait.

Let the bigint project be its own thing and release when it's "internally" logical to do so. One option is to let the MSRV bump be a one-feature release (i.e. release 0.6 without const_mut_refs and then make a 0.7 with the MSRV bump).

@tarcieri
Copy link
Member Author

Rust 1.83 is coming out on November 28th, a week away. We can at least wait for that.

A release thereafter might make sense.

@ycscaly
Copy link
Contributor

ycscaly commented Dec 26, 2024

Hey @tarcieri any update as to the release date? Also, is there a changelog?
Rebasing my code on 0.6.0-rc.6 proved a difficult and worrisome task, with many surpising breaking changes:

  • using u32 for bits instead of usize
  • multiplication with * is not wide anymore
  • shift operations with << etc has changed their functionality
    Honestly, my code "works", but I am very much afraid hidden somewhere deep inside is a bug that simply isn't cuaghet by any tests that was introduced because of a breaking change I wasn't aware/didn't understand its signficance.

I'm not sure if the original plan was to make such a hard-breaking release, and if you knew it would take so much effort to be upgraded, but in any case a thorough changelog that explains the breaking changes and their implications would ease my mind a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants