Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Instructions to reproduce fiat-crypto files #1007

Open
jhand2 opened this issue Jan 5, 2024 · 2 comments
Open

Request: Instructions to reproduce fiat-crypto files #1007

jhand2 opened this issue Jan 5, 2024 · 2 comments

Comments

@jhand2
Copy link

jhand2 commented Jan 5, 2024

Would it be feasible to document the configurations were used to generate the fiat-crypto arithmetic used in this crate? In particular:

In particular:

  • Which version of fiat-crypto was used as the source
  • Which version of fiat-constify was used

This would help to be able to ensure the files in this crate match some specific fiat-crypto release.

@tarcieri
Copy link
Member

tarcieri commented Jan 6, 2024

We can have fiat-constify at least embed a comment in the transformed files.

It's somewhat annoying that in all of the comments fiat-crypto generates about its inputs, it doesn't include its own version. That might be something worth reporting upstream?

@tarcieri
Copy link
Member

Something that might be interesting (especially as I'm pondering upgrading all of the backends) is turning fiat-constify into a tool that automates the entire code generation process, possibly with some kind of config file checked into the repo that says which of the various codegen options to use

@RustCrypto RustCrypto deleted a comment from fslmultiservice22 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@tarcieri @jhand2 and others