-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve secp256k1 field multiplication speeds #24
Comments
Not quite. I'd like to write some benchmarks for myself and talk with @fjarri a bit before it gets closed. |
What multiplication are we talking about here? Scalar-scalar, field-field, or point-scalar? The latter can certainly be improved, I'm planning to look into it. Where's this benchmark you're quoting, by the way? |
I've unfortunately lost the benchmark I originally wrote, but it measured point-scalar. It would be nice to see two benchmarks, 1) comparing point-scalar operations to |
I think we can go ahead and close this out. Further optimizations would certainly be appreciated, but I think we're ok for now. |
Presently, the
k256
crate implements montgomery mulmod for multiplication/reduction. @hdevalence brought up a point in #19 that there may be a method that leverages the special form of the secp256k1 modulus to improve multiplication performance.Performance of a scalar multiplication for the
k256
crate:It would be nice to see a significant performance increase for this.
The text was updated successfully, but these errors were encountered: