Use the SHA-NI extension backend with enabled asm feature #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making this change. Would it make sense to do the same thing with SHA1 in addition to SHA2? I'm in a similar situation where I'd like to use the SHA1 intrinsic if available, otherwise fall back to the asm implementation. As-is it seems like the |
|
I went ahead and created #225 to apply the same change to SHA1. |
|
Thank you! This does solve our problem. |
This was referenced Mar 15, 2021
tarcieri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SHA extension backend is significantly faster then our ASM code, so with this change on x86 targets we first will check if CPU has the extension and only then we will fallback either to ASM or software implementation.
Closes #220.
cc @dgbo