-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify block-cipher
and stream-cipher
into cipher
#337
Conversation
6a907ed
to
b8d86d5
Compare
@newpavlov if this looks good to you, can you add @RustCrypto/traits as owner of the I can take care of updating all of the respective crates that presently (transitively) depend on |
b8d86d5
to
ef1afd9
Compare
We are now owners of the `cipher` crate: https://crates.io/crates/cipher This commit unifies the existing `block-cipher` and `stream-cipher` crates into the `cipher` crate, placing their code under the `cipher::block` and `cipher::stream` modules respectively. Ideally this means the crate is a drop-in replacement, and all end users need to do is `s/block_cipher/cipher::block/` and `s/stream_cipher/cipher::stream` to upgrade.
ef1afd9
to
92075dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this looks good to you, can you add @RustCrypto/traits as owner of the cipher crate?
Done!
Awesome, thanks! |
This PR replaces all previous usages of the `block-cipher` and `stream-cipher` crates with the new unified `cipher` crate. See also: RustCrypto/traits#337
This PR replaces all previous usages of the `block-cipher` and `stream-cipher` crates with the new unified `cipher` crate. See also: RustCrypto/traits#337
This PR replaces all previous usages of the `block-cipher` and `stream-cipher` crates with the new unified `cipher` crate. See also: RustCrypto/traits#337
We are now owners of the
cipher
crate:https://crates.io/crates/cipher
This commit unifies the existing
block-cipher
andstream-cipher
crates into thecipher
crate, placing their code under thecipher::block
andcipher::stream
modules respectively.Ideally this means the crate is a drop-in replacement, and all end users need to do is
s/block_cipher/cipher::block/
ands/stream_cipher/cipher::stream
to upgrade.