Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dangerous assertion? #53

Closed
hematthi opened this issue May 26, 2022 · 3 comments
Closed

dangerous assertion? #53

hematthi opened this issue May 26, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@hematthi
Copy link
Collaborator

EchelleCCFs.jl/src/ccf/calc_ccf.jl

Line 31 in a639217

@assert assume_sorted || issorted( plan.line_list.λ )

Isn't this dangerous if issorted( plan.line_list.λ ) is false but assume_sorted=true? I imagine you'd want to be sure that plan.line_list.λ is sorted
@hematthi hematthi added the help wanted Extra attention is needed label May 26, 2022
@hematthi
Copy link
Collaborator Author

EchelleCCFs.jl/src/ccf/calc_ccf.jl

Line 77 in a639217

@assert assume_sorted || issorted( plan.line_list.λ )

@hematthi
Copy link
Collaborator Author

EchelleCCFs.jl/src/ccf/calc_ccf.jl

Line 131 in a639217

@assert assume_sorted || issorted( plan.line_list.λ )

@eford
Copy link
Member

eford commented Jun 26, 2022

assume_sorted is an optimization flag. Yes, it's dangerous to say true when it's not.

@eford eford closed this as completed Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eford @hematthi