Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default value for plan_for_chunk optional argument does not match type #72

Closed
hematthi opened this issue May 31, 2022 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@hematthi
Copy link
Collaborator

function calc_order_ccfs_chunklist!(chunk_ccfs_out::AbstractArray{T1,2}, chunk_list::AbstractChunkList,
plan_for_chunk::AbstractVector{PlanT} = BasicCCFPlan(); assume_sorted::Bool = false ) where {
T1<:Real, PlanT<:AbstractCCFPlan }

plan_for_chunk must be a vector of PlanT types, but BasicCCFPlan() returns only one PlanT object

@hematthi hematthi added the bug Something isn't working label May 31, 2022
@hematthi
Copy link
Collaborator Author

Same for:

function calc_order_ccfs_chunklist(chunk_list::AbstractChunkList,
plan_for_chunk::AbstractVector{PlanT} = BasicCCFPlan();
Δfwhm::Real = 0, assume_sorted::Bool = false ) where {
PlanT<:AbstractCCFPlan }

@hematthi
Copy link
Collaborator Author

Same for:

function calc_order_ccf_and_vars_chunklist!(chunk_ccfs_out::AbstractArray{T1,2}, chunk_ccf_vars_out::AbstractArray{T1,2}, chunk_list::AbstractChunkList,
plan_for_chunk::AbstractVector{PlanT} = BasicCCFPlan(); assume_sorted::Bool = false ) where {
T1<:Real, PlanT<:AbstractCCFPlan }

@hematthi
Copy link
Collaborator Author

function calc_order_ccf_and_vars_chunklist(chunk_list::AbstractChunkList,
plan_for_chunk::AbstractVector{PlanT} = BasicCCFPlan();
Δfwhm::Real = 0, assume_sorted::Bool = false ) where {
PlanT<:AbstractCCFPlan }

@eford eford closed this as completed in 615d62e Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant