Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v_offset and σ_sqrt2 should be fields of m #85

Closed
hematthi opened this issue Jun 11, 2022 · 0 comments
Closed

v_offset and σ_sqrt2 should be fields of m #85

hematthi opened this issue Jun 11, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@hematthi
Copy link
Collaborator

function cdf(m::GaussianMixtureCCFMask, v_lo::Real,v_hi::Real, i::Integer)
m.cdf_normalization[i]*( erf((v_hi-v_offset[i])/σ_sqrt2[i]) - erf((-v_lo-v_offset[i])/σ_sqrt2[i]) )
end

Could also add an assert to make sure index is valid for the number of mixtures, i.e. 1 <= i <= length(m.weight)

@hematthi hematthi added bug Something isn't working enhancement New feature or request labels Jun 11, 2022
@eford eford closed this as completed in f5efc31 Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant