Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated oled_task_user code #4

Closed
bax09 opened this issue Jun 13, 2022 · 3 comments
Closed

Outdated oled_task_user code #4

bax09 opened this issue Jun 13, 2022 · 3 comments
Labels
accepting PR accepting a PR to fix bug Something isn't working

Comments

@bax09
Copy link

bax09 commented Jun 13, 2022

OLED task function changed to be boolean qmk/qmk_firmware#14864
Yet the keymap is still using "void oled_task_user(void)"
Compiling puts out an error

@Rwarcards762
Copy link
Owner

Thanks for pointing this out! I haven't recompiled this code in a while so I haven't seen that.

Looking into the QMK docs it's hard to see this change other than via the examples. It looks as though now instead of a void it is a bool that just return False at the end. If you have made those changes and can confirm they work, feel free to open an MR with the fix and I'll test it this weekend.

Otherwise I'll try and get around to testing that the fix works this weekend and commit the change myself.

@Rwarcards762 Rwarcards762 added bug Something isn't working accepting PR accepting a PR to fix labels Jun 13, 2022
@Rwarcards762
Copy link
Owner

Rwarcards762 commented Jun 21, 2022

Didn't end up getting to it this past weekend -- I'll see about getting to it soon when I get the chance to bring my board home.

@Rwarcards762
Copy link
Owner

Fixed with merge, thanks @MinXuann :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PR accepting a PR to fix bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants