Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas still injected even if trails are off #581

Open
Cqoicebordel opened this issue Nov 19, 2021 · 0 comments
Open

Canvas still injected even if trails are off #581

Cqoicebordel opened this issue Nov 19, 2021 · 0 comments

Comments

@Cqoicebordel
Copy link

In 1.5.5 from the store, it looks like the canvas is still injected even if all the drawing options are turned off (trail+action+text).

It shouldn't be important, except for 2 reasons :

  • I use the "Dark Reader" extension (with "static" setting), which invert a lot of colors, including the canvas when I start a mouse gesture, blacking out the whole screen. It's not a big bug, but it's annoying, especially since I have a tendency to start a gesture before finishing reading the page.
  • By trying to debug it, I saw that there was code to handle that case, but it didn't seem to work, and that bothered me. In particular, that snippet
content_scripts.ts:133
if ( ! this.option.isTrailOn()) {
    return;
}

When debugging, I saw that Chrome didn't go inside the if, even if ! this.option.isTrailOn() was true when typed in the console.

I don't know typescript, and I'm almost a noob about extensions, so I'm not sure what is the issue. Maybe this particular snippet gets removed when "compiling" it ? I have no idea.

In any case, I have created a workaround for myself, by setting the canvas z-index to -10000. That's good enough for me right now, but I thought you should know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant