Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default signing algorithm to not use broken SHA-1 hashing algorithm #289

Closed
timabbott opened this issue Oct 20, 2021 · 3 comments
Closed

Comments

@timabbott
Copy link

@pitbulk I just wanted to follow up on #269; using a hashing algorithm that's been broken in an authentication library isn't a reasonable default, even for backwards-compatibility. The right thing to do is to do a release that changes the default (and document that the SHA-1 algorithms are deprecated).

See https://duo.com/decipher/sha-1-fully-and-practically-broken-by-new-collision and https://duo.com/decipher/openssh-will-deprecate-sha-1 for background -- SHA-1 is deprecated and should not be used.

@mateuszmandera
Copy link

To add a bit more information here, what should be changed is not only the default setting that python-saml and python3-saml use for generating signatures, but also the logic for validating signatures on SAMLResponses/LogoutRequests received, which currently accepts these rsa-sha1 signatures. Arguably, there should at least be a setting to reject these signatures (and I think ideally it would be on by default because as mentioned above, backward compatibility doesn't seem like a stronger reason that the insecurity of the algorithm).

@pitbulk
Copy link
Contributor

pitbulk commented Dec 14, 2021

Ok, I will implement such change on next release of python-saml / python3-saml and on rest of toolkits.
I will also implement the "reject unsecure algorithms" by default enable

@pitbulk
Copy link
Contributor

pitbulk commented Jan 28, 2022

Done

@pitbulk pitbulk closed this as completed Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants