Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in docs #111

Closed
guettli opened this issue Oct 1, 2019 · 1 comment
Closed

Typo in docs #111

guettli opened this issue Oct 1, 2019 · 1 comment

Comments

@guettli
Copy link
Contributor

guettli commented Oct 1, 2019

There is a typo in the docs at https://sap.github.io/PyRFC/client.html

The example source code starts with these two lines:

except ModuleNotFoundError as e:
    from configparser import ConfigParser

This does not make any sense.

Maybe something like this would make sense to support Python2 and Python3 (untested)

try:
    from ConfigParser import ConfigParser
except ImportError:
    from configparser import ConfigParser
@bsrdjan
Copy link
Contributor

bsrdjan commented Oct 9, 2019

Fixed in 1.9.98

@bsrdjan bsrdjan closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants