Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[needs triage] Extending Add To Cart #10428

Open
ymirek opened this issue Dec 15, 2020 · 1 comment
Open

[needs triage] Extending Add To Cart #10428

ymirek opened this issue Dec 15, 2020 · 1 comment

Comments

@ymirek
Copy link

ymirek commented Dec 15, 2020

Is your feature request related to a problem? Please describe.
It's often required to extend add to cart with additional parameters (like transport unit, delivery date or others).
We would like to extend this method but requireLoadedCart() is private:

Describe the solution you'd like
Make requireLoadedCart() protected or public

Describe alternatives you've considered
No other choice than duplicating entire ActiveCartService.

Additional context

@Xymmer Xymmer added this to the needs-triage milestone Feb 2, 2021
@Xymmer Xymmer changed the title Extending Add To Cart [needs triage] Extending Add To Cart Feb 2, 2021
@Platonn
Copy link
Contributor

Platonn commented Feb 2, 2021

It's already made public in Spartacus 3.1.0-next.0 (PR #5347).

@Xymmer Xymmer removed this from the needs-triage milestone Oct 26, 2021
@Xymmer Xymmer added this to the validate-before-moving-to-jira milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants